Closed
Bug 975423
Opened 11 years ago
Closed 11 years ago
Don't show sync promo banner ever again after user hits close button
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox29 fixed, firefox30 verified, fennec29+)
VERIFIED
FIXED
Firefox 30
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bnicholson
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In bug 961523, we went for a fix that only affects banners created from snippets from the snippets server, the sync banner is different, so we'll need a different solution there. A simple pref should do the job.
|
Assignee | |
Comment 1•11 years ago
|
||
This is more straightforward, since there's only one banner message to worry about, and we already have a pref that controls whether or not to show that message.
Attachment #8379940 -
Flags: review?(bnicholson)
|
||
Updated•11 years ago
|
Attachment #8379940 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/347661bfb3e4
We'll want to uplift this.
tracking-fennec: --- → 29+
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
status-firefox30:
--- → verified
|
|
Assignee | |
Updated•11 years ago
|
status-firefox29:
--- → affected
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8379940 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): sync promo banner (for new sync)
User impact if declined: promo banner can re-appear if user his close button
Testing completed (on m-c, etc.): landed on m-c 2/23
Risk to taking this patch (and alternatives if risky): low-risk, sets pref to disable sync promo banner when user hits close button
String or IDL/UUID changes made by this patch: none
Attachment #8379940 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
Attachment #8379940 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•