Closed
Bug 975917
Opened 11 years ago
Closed 11 years ago
[Everything.me] Tapping homebutton while in Collection Rename mode may cause freeze
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)
Firefox OS Graveyard
Gaia::Everything.me
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)
RESOLVED
FIXED
blocking-b2g | 1.3+ |
People
(Reporter: sync-1, Assigned: amirn)
References
()
Details
Attachments
(3 files)
(deleted),
video/3gpp
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-github-pull-request
|
ranbena
:
review+
fabrice
:
approval-gaia-v1.3+
|
Details |
Firefox OS v1.3
Mozilla build ID: 20140208004002
DEFECT DESCRIPTION:
MS will freeze when fast touch these folders "Social" "Games" "Music" "Showbiz" and home key.
REPRODUCING PROCEDURES:
At home screen, fast touch "Social" /"Games"/ "Music" /"Showbiz" and home key many times, MS will freeze in "Social" /"Games"/ "Music" /"Showbiz" interface.--KO
EXPECTED BEHAVIOUR:
MS shouls not freeze when fast touch "Social" /"Games"/ "Music" /"Showbiz" and home key.
ASSOCIATE SPECIFICATION:
TEST PLAN REFERENCE:
TOOLS AND PLATFORMS USED:
USER IMPACT:
REPRODUCING RATE:
For FT PR, Please list reference mobile's behavior:
Comment 1•11 years ago
|
||
Can you include a video? That will help explain how fast we need to move to trigger the bug.
Flags: needinfo?(sync-1)
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Comment 3•11 years ago
|
||
The other thing we should find out here is if it's still possible to power down or restart the device when you hit this bug.
Flags: needinfo?(sync-1)
Comment 4•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #3)
> The other thing we should find out here is if it's still possible to power
> down or restart the device when you hit this bug.
Yes, it can restart the phone.
Just find a relatively easy way to reproduce this issue:
1. Enter one collection, for example, Social
2. In Social collection, tap the title "Social" and then tap the Home key really fast, like a one-two punch, you must tap the home key before the virtual keyboard come up.
3. Screen will freeze.
You need to operate quickly to reproduce this issue, but once it happens, you need to press power key to restart the handset, otherwise it will forever freeze in that screen
Comment 6•11 years ago
|
||
We can find which causes this issue is the function this.Rename.done (in Collection.js). And sometimes the keyboard stay on the homescreen when no input field has focus.
Comment 7•11 years ago
|
||
Amir, can you take a look at this? See what component is responsible.
Flags: needinfo?(amirn)
Assignee | ||
Comment 8•11 years ago
|
||
I am investigating. Might be a duplicate of bug 968628.
Flags: needinfo?(amirn)
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #8381336 -
Flags: review?(ran)
Assignee | ||
Comment 10•11 years ago
|
||
Abrupt taps raised some issues timing issues with the Collection.Rename module.
E.me captures the homebutton tap but uncaught exceptions were blocking it from hiding the Rename UI. This caused the UI "freeze" and force the user to reboot.
I tried to make this patch as small as possible so it will be safe to land on 1.3.
For future reference, these errors showed up in the log:
(1) E/GeckoConsole( 2564): [JavaScript Error: "TypeError: elInput is null" {file: "app://homescreen.gaiamobile.org/everything.me/modules/Collection/Collection.js" line: 118}]
(2) Reported by bkelly in bug 968628
E/GeckoConsole( 3030): [JavaScript Error: "TypeError: currentSettings is null" {file: "app://homescreen.gaiamobile.org/everything.me/modules/Collection/Collection.js" line: 116}]
Summary: [Sora][MMI] MS will freeze when fast touch these folders "Social" "Games" "Music" "Showbiz" and home key. → [Everything.me] Tapping homebutton while in Collection Rename mode may cause freeze
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → amirn
Comment 12•11 years ago
|
||
Comment on attachment 8381336 [details]
Github Pull Request
Awesome. Couldn't reproduce.
Attachment #8381336 -
Flags: review?(ran) → review+
Assignee | ||
Comment 13•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 14•11 years ago
|
||
Comment on attachment 8381336 [details]
Github Pull Request
[v1.3 Approval Request Comment]
[Bug caused by]: bug 911550
[User impact] if declined: device might freeze when trying to rename a Collection and then quickly tapping the home button
[Risk to taking this patch]: Very Low. Changes only in Collection.Rename module
[String changes made]: Added safeguards
Attachment #8381336 -
Flags: approval-gaia-v1.3?
Comment 15•11 years ago
|
||
Given a phone restart is needed to get out of the freeze, lets uplift the low risk patch to avoid this regression.
blocking-b2g: 1.3? → 1.3+
Updated•11 years ago
|
Attachment #8381336 -
Flags: approval-gaia-v1.3? → approval-gaia-v1.3+
Comment 16•11 years ago
|
||
Uplift successful
Uplifted f03f667e1d92595df8bfddd8b0f0f7ec64d28230 to:
* v1.3: b04d2a814a9916e63a51089ca62bba1ec52720b4
status-b2g-v1.3:
--- → fixed
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → fixed
Updated•11 years ago
|
Flags: in-moztrap?
Updated•11 years ago
|
Flags: in-moztrap? → in-moztrap+
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•