Closed Bug 976609 Opened 11 years ago Closed 10 years ago

Thread Pane: After dialog confirmation highlight color is missing every second row

Categories

(Thunderbird :: Theme, defect)

29 Branch
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: soeren.hentzschel, Unassigned)

References

Details

Hi!

The selected messages in the list of (newsgroups) messages are highlighted with a blue background on OS X. Select a row and press the backspace key, a confirmation dialog for the deletion of the message appears. It doesn't matter if you confirm or cancel the deletion, after that the highlight color is missing in every second row. Click different messages in the list an compare before the dialog and after. After switching to another newsgroups or mail account and back it works again as expected.

The described behaviour occurs in current Daily (30) and Earlybird (29), not in Beta / Stable (27).
Any change to themes in the referenced TB versions?
The default theme is enabled in all versions.
I do see this on Daily. Not probably a theme issue, as we definitely have the capability of handling things properly since it does work before this dialog appears. 

Also, this appears to happen with several kinds of dialogs. (I've triggered this repeatedly by using the 'n' key until you're out of unread messages and a dialog pops up)

So aceman, this is most likely related to whatever code runs when closing a dialog. Not sure where that would be though.

This may be related to bug 976583 actually.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Newsgroups: After deletion confirmation highlight color is missing every second row → Thread Pane: After dialog confirmation highlight color is missing every second row
Does it miss the blue highlight (active selection) or also the grey highlight (passive selection) as when TB window does not have focus?
Everything switches to a passive highlight, but the even threads lack any kind of highlight.
So I can see TB falling into the passive highlight (grey on Win XP) after dismissing some dialogs (e.g. tags->New tag->Cancel). Then I can select new messages (clicking them) and they still only get this passive highlight. I can regain the active hightlight (blue) for the currently selected messages by swithing to another window, or clicking into other pane inside TB, just outside of the message list. Looks like after showing a dialog, the message list widget (a <tree>) is confused whether it still has focus.
It even misses the grey highlight without confirmation dialog, but the highlight reappers after switching back to Thunderbird.

Thunderbird Stable / Beta:

1. Select a row with the darker highlight color, it is highlighted blue
2. give another application the focus, the selected row has a grey highlight
3. switch back to Thunderbird, the row has a blue highlight color
4. press the backspace key and confirm or cancel the dialog, highlighting of the row works as expected
5. give another application the focus, the selected row has a grey highlight
6. switch back to Thunderbird, the row has a blue highlight color

Thunderbird Daily:

1. Select a row with the darker highlight color, it is highlighted blue
2. give another application the focus, the selected row has no longer a highlight color
3. switch back to Thunderbird, the row has a blue highlight color
4. press the backspace key and confirm or cancel the dialog, the highlight color is missing
5. give another application the focus, the selected row has a grey highlight
6. switch back to Thunderbird, the row has a blue highlight color
What I see in comment 6 also happens in the folder pane, also a <tree> XUL element.
It also happens when a dialog is confirmed, e.g. New subfolder.
May be a bug in toolkit?
Might be a core focus bug; I see the problem with other elements that use focus events.
Alternatively might possibly be an alert-suppressing-events bug.
Last good Daily: 2013-12-17
First bad Daily: 2013-12-19
Please retest this after the fix to bug 956704 lands. I believe that should fix this.
Depends on: 956704
(In reply to Sören Hentzschel from comment #7)
> 1. Select a row with the darker highlight color, it is highlighted blue
> 2. give another application the focus, the selected row has no longer a highlight color
> 3. switch back to Thunderbird, the row has a blue highlight color
> 4. press the backspace key and confirm or cancel the dialog, the highlight color is missing
> 5. give another application the focus, the selected row has a grey highlight
> 6. switch back to Thunderbird, the row has a blue highlight color

Step 4 is fixed, step 2 is not fixed. Additionally there should be a grey highlight color while the confirmation dialog is visible, but it is missing in current Daily and present in Beta.
Blocks: 976583
(In reply to Sören Hentzschel from comment #13)
> (In reply to Sören Hentzschel from comment #7)
> > 1. Select a row with the darker highlight color, it is highlighted blue
> > 2. give another application the focus, the selected row has no longer a highlight color
> > 3. switch back to Thunderbird, the row has a blue highlight color
> > 4. press the backspace key and confirm or cancel the dialog, the highlight color is missing
> > 5. give another application the focus, the selected row has a grey highlight
> > 6. switch back to Thunderbird, the row has a blue highlight color
> 
> Step 4 is fixed, step 2 is not fixed. Additionally there should be a grey
> highlight color while the confirmation dialog is visible, but it is missing
> in current Daily and present in Beta.

Sören, is step 2 still not working for you? For me it's working.
Flags: needinfo?(cadeyrn)
Yes, it seems to be fixed.
Flags: needinfo?(cadeyrn)
(In reply to Sören Hentzschel from comment #16)
> Yes, it seems to be fixed.

Thank you.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.