Closed
Bug 976638
Opened 11 years ago
Closed 11 years ago
New tab controls.png should be the same across platforms
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 31
People
(Reporter: Mardak, Assigned: mzhilyaev)
References
Details
(Whiteboard: p=2 s=it-31c-30a-29b.2 [qa!])
From bug 974736 comment 17, the new tab controls should be the same across windows, osx, linux; but they're slightly different:
- pins pointing down vs diagonally
- shadow
- contrast of tiles toggle
Which set of icons are desired?
We can make it consistent in fixing bug 974736.
Updated•11 years ago
|
Component: Tabbed Browser → Theme
Updated•11 years ago
|
Whiteboard: [tiles] p=0
Updated•11 years ago
|
Blocks: fxdesktopbacklog
Reporter | ||
Comment 1•11 years ago
|
||
Our current patches take the mac controls.png:
https://bugzilla.mozilla.org/attachment.cgi?id=8381140&action=edit
It's the one with down pins when pinned.
Is that acceptable, shorlander?
Flags: needinfo?(shorlander)
Reporter | ||
Comment 2•11 years ago
|
||
Boriss, bug 974736 fixes this by using the mac icons and putting it in the shared directory for windows and linux. Just confirming that decision is okay.
Flags: needinfo?(shorlander) → needinfo?(jboriss)
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Assignee: nobody → jboriss
Whiteboard: [tiles] p=0 → [tiles] p=2 s=it-30c-29a-28b.3
Updated•11 years ago
|
Whiteboard: [tiles] p=2 s=it-30c-29a-28b.3 → [tiles] p=2 s=it-30c-29a-28b.3 [qa+]
Updated•11 years ago
|
QA Contact: twalker
Comment 3•11 years ago
|
||
(In reply to Ed Lee :Mardak from comment #2)
> Boriss, bug 974736 fixes this by using the mac icons and putting it in the
> shared directory for windows and linux. Just confirming that decision is
> okay.
Yep, that's ok!
Flags: needinfo?(jboriss)
Comment 4•11 years ago
|
||
Marking this as invalid per Comment 2: we'll be using a shared directory for these files.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Updated•11 years ago
|
Assignee: jboriss → nobody
QA Contact: twalker
Whiteboard: [tiles] p=2 s=it-30c-29a-28b.3 [qa+]
Reporter | ||
Comment 5•11 years ago
|
||
This bug is something that needs to be fixed. We happen to be fixing it in bug 974736. I'll resolve this bug when the code there lands.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Reporter | ||
Comment 6•11 years ago
|
||
Reporter | ||
Comment 7•11 years ago
|
||
Reporter | ||
Comment 8•11 years ago
|
||
Updated•11 years ago
|
Whiteboard: p=0 s=it-31c-30a-29b.2
Updated•11 years ago
|
Assignee: nobody → mzhilyaev
Target Milestone: --- → Firefox 31
Updated•11 years ago
|
Whiteboard: p=0 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2
Florin, can you assign this to someone on your team? Thanks!
Flags: needinfo?(florin.mezei)
Whiteboard: p=2 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2 [qa+]
Updated•11 years ago
|
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Updated•11 years ago
|
Flags: needinfo?(florin.mezei)
QA Contact: cornel.ionce
Comment 10•11 years ago
|
||
Verified in latest Nightly (build ID: 20140402030201) that the new tab controls are the same across platform. The controls are the ones from https://bugzilla.mozilla.org/attachment.cgi?id=8381140.
Testing was performed on Windows 7 64bit, Ubuntu 12.4 32bit, Mac OS X 10.9 and Windows 8.1 64bit (MS Surface Pro 2).
Status: RESOLVED → VERIFIED
Whiteboard: p=2 s=it-31c-30a-29b.2 [qa+] → p=2 s=it-31c-30a-29b.2 [qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•