Closed
Bug 976668
Opened 11 years ago
Closed 11 years ago
Fix sort order for retriggered jobs that don't have a part number
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
For jobs that do not have a part number, jobPartNumber() returns the empty
string and so parseInt() returns NaN. This means that for two identical jobs
(such as retriggers) without a part number, aNum and bNum are both NaN.
NaN compared to itself isn't equal, which breaks the (aNum != bNum) condition,
and so the sort. To workaround, we assign job types without a part number the
number zero.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8381562 -
Flags: review?(ryanvm)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8381562 [details] [diff] [review]
Patch v1
Review of attachment 8381562 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8381562 -
Flags: review?(ryanvm) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
In production :)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•