Current mozilla-inbound spams this build warning: { js/src/gc/RootMarking.cpp:251:1: warning: unused function 'MarkWordConservatively' [-Wunused-function] } Looks like bug 975947 just increased the scope of some #ifndeffing to now be wrapping a caller (in similarly-named "MarkRangeConservatively") that was forrmerly not #ifndefffed: http://hg.mozilla.org/integration/mozilla-inbound/diff/a278b0807420/js/src/gc/RootMarking.cpp So before that change, this function was used. Now it's not used, in builds where the #ifndef-protected code is turned off. Perhaps the #ifndef wants to move up above MarkWordConservatively?

This moves the #ifndef up to before the "unused" function, as suggested in comment 0. I verified this fixes my build warning. I also verified that I can still build with ac_add_options --disable-exact-rooting (which is the build flag that controls this #ifndeffed symbol).

Comment on attachment 8382756 [details] [diff] [review] fix v1 Review of attachment 8382756 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=me