Closed Bug 976773 Opened 11 years ago Closed 10 years ago

Simulator build of B2G 1.4 for app-manager

Categories

(Firefox OS Graveyard :: Simulator, defect)

Product:
Firefox OS Graveyard
Component:
Simulator
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S6 (25apr)
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
firefox30 --- fixed
firefox31 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: andy+bugzilla, Assigned: ochameau)

References

Details

Attachments

(1 file)

Fix simulator path on Windows and fix the simulator addon versioning.
(deleted), patch
jryans
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
I was playing around with some new features in B2G, so fired up the app-manager keen to try them out. But then was sad faced to find out that simulator builds are for 1.2 or 1.3 at the moment.

https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/

A 1.4 build so I can use it with the app-manager would be super awesome.
This is definitely in the works!  We've been refactoring how we build the Simulator, so that we'll soon have nightly Simulator builds available.

I'm hopeful that we'll have a 1.4 build later this week.
Depends on: 920198
Awesome!  I have so many partners blocking on needing 1.4, but I don't want to ask them to flash their phones (since we don't have public builds for our devices).  Please please please let me know ASAP when this lands, or if the timeline changes!
I had to fix some issues on windows, where file path to b2g desktop was wrong,
and also tweak the addon version we are using to prevent big ints in it.
(It was preventing the addon from being updated)

I pushed a new try for 1.5 builds:
  https://tbpl.mozilla.org/?tree=Try&rev=f176d3e047b0
Attachment #8400713 - Flags: review?(jryans)
Assignee: nobody → poirot.alex
Depends on: 944443, 990065, 935014
And here is a try of try run for 1.4, hopefully it does what I'm expecting:
  https://tbpl.mozilla.org/?tree=Try&rev=f6d752179b73
Patch looks good, but the 1.5 try run you posted above fails on Mac for me.  It appears to not include the promise fix.
Same player, shoot again, I now missed bug 990065 backout in 1.5...
  https://tbpl.mozilla.org/?tree=Try&rev=2eb76aad0af4
I tested the Mac 1.5 build from comment 7, and it appears to work well here.  Plus fonts support too! :D

I also tried the Mac 1.4 build from comment 6, but it seems you left out the Mac binary path / Gaia deduplication patch from bug 987411, so it fails to start.
Ok, pulled it in this new try:
  https://tbpl.mozilla.org/?tree=Try&rev=f7f1c0f1678d

I'm currently uploading 1.5 xpis to labs ftp!
Depends on: 987411
You should also update the HTML page to link to the new Simulator versions as well.
The windows build of the previous 1.4 try looks good! We are having gaia 1.4. Try push builds are so great!!!
Yes, but let first distribute the ftp links internaly for some tests.
Then we can distribute new version massively.
Here is 1.5 build candidates:
  https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/1.5/

Nick, would you mind giving them a try?
Once we get them tested internally, we will update the installation page:
  https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/
Please do not share the link to the ftp folders broadly in the meantime.
Keywords: checkin-needed, leave-open
Looks good!  The animation of opening an app is not very smooth, but that's a separate issue.  Ship it!
Looks like we also miss bug 984929 to get a functional debugger on 1.4
I can remote debug fine in 1.5 so I'm guessing comment 15 only applies to 1.4.  Curiously, I can no longer command+q on 1.5.
Yes. There is a new loss of feature compared to previous versions.
Now starting with 1.4, the simulator no longer tweaks b2g desktop.
Instead I uplifted all simulator tweaks to b2g desktop, so that b2g desktop is the simulator (more or less). One all depdendent patches are going to land on mozilla central, b2g desktop will have same features than the simulator version.
It was important to merge all these tweaks to ease maintaining the simulator and prevent having different experiences on Desktop. The tradeoff is that we again loss some features, like the native menu and shortkeys. On positive side, the rotation feature had various bug being fixed. Also we should have nightly build of the simulator soon!
BTW please keep posting anything you find missing/broken. Your reports have a lot of value!
1.4 build from comment 16 is missing patch from bug 988563, so it shows no window on Macs.
1.4 also is missing the font fix from bug 925833, which would be good to include too.
Depends on: 988563
I'm only planning to uplift the critical patches to make the simulator work on 1.4.
If you want the font patch, you can still ask it to be uplifted.

New 1.4 candidate with mac fix:
  https://tbpl.mozilla.org/?tree=Try&rev=44b36ed24957
(In reply to Alexandre Poirot (:ochameau) from comment #22)
> I'm only planning to uplift the critical patches to make the simulator work
> on 1.4.
> If you want the font patch, you can still ask it to be uplifted.
> 
> New 1.4 candidate with mac fix:
>   https://tbpl.mozilla.org/?tree=Try&rev=44b36ed24957

Yay, this one works great! :D
I just uploaded 1.4 builds to the ftp:
  https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/1.5/

I tested windows and linux builds. If anyone can give it a try, feedback is also welcomed!
Sorry, yes.

Just updated the simulator page to show 1.5:
  https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/
Hey to the release management team!

I'm not sure 1.4? is the right flag to proceed, but we would like to uplift a few patches to 1.4 branch, so that we can spawn 1.4 simulator builds. As it requires to uplift a bulk of patches (all blockers of this bug), I would like to first know if that reasonable request before flaging all the patches!
Most of these patches are desktop specific, so that it should only impact b2g desktop.
Very few modify device codepath. 

Here is the precise list of patches, ordered by landing:

  bug 944443 attachment 8392858 [details] [diff] [review]
             attachment 8392935 [details] [diff] [review]
    very naive modification of shell.html/shell.js
  bug 935014 attachment 8395670 [details] [diff] [review]
    desktop code only
  bug 987411 attachment 8397187 [details] [diff] [review]
    desktop code only
  bug 988563 attachment 8398212 [details] [diff] [review]
    followup of bug 944443, naive modification of shell.html
  bug 976773 attachment 8400713 [details] [diff] [review]
    desktop code only
  bug 990065 attachment 8404058 [details] [diff] [review]
    followup of bug 8400713, desktop code only
  bug 920198 attachment 8403340 [details] [diff] [review]
             attachment 8400721 [details] [diff] [review]
    nightly mozconfig tweaks
blocking-b2g: --- → 1.4?
Just forgot about bug 990057 attachment 8400759 [details] [diff] [review], desktop code only, with a aurora specific patch.
(that's the only patch the doesn't apply as-is on aurora)
Depends on: 990057
Approval gaia please
blocking-b2g: 1.4? → backlog
(In reply to Preeti Raghunath(:Preeti) from comment #32)
> Approval gaia please. You may request it for 1.4.
Have you looked at comment 30?
This is a set of patches and all are targeting mozilla-central, so it isn't gaia patches.
Flags: needinfo?(praghunath)
Comment on attachment 8400713 [details] [diff] [review]
Fix simulator path on Windows and fix the simulator addon versioning.

See bug 976773 comment 30.
We would like to build 1.4 simulators and need to uplift mostly desktop-specific patches.

This patch modify only desktop codepath.
Attachment #8400713 - Flags: approval-mozilla-aurora?
(In reply to Alexandre Poirot (:ochameau) from comment #30)
> Hey to the release management team!
> 
> I'm not sure 1.4? is the right flag to proceed, but we would like to uplift
> a few patches to 1.4 branch, so that we can spawn 1.4 simulator builds. As
> it requires to uplift a bulk of patches (all blockers of this bug), I would
> like to first know if that reasonable request before flaging all the patches!
> Most of these patches are desktop specific, so that it should only impact
> b2g desktop.
> Very few modify device codepath. 
> 
> Here is the precise list of patches, ordered by landing:
> 
>   bug 944443 attachment 8392858 [details] [diff] [review]
>              attachment 8392935 [details] [diff] [review]
>     very naive modification of shell.html/shell.js
>   bug 935014 attachment 8395670 [details] [diff] [review]
>     desktop code only
>   bug 987411 attachment 8397187 [details] [diff] [review]
>     desktop code only
>   bug 988563 attachment 8398212 [details] [diff] [review]
>     followup of bug 944443, naive modification of shell.html
>   bug 976773 attachment 8400713 [details] [diff] [review]
>     desktop code only
>   bug 990065 attachment 8404058 [details] [diff] [review]
>     followup of bug 8400713, desktop code only
>   bug 920198 attachment 8403340 [details] [diff] [review]
>              attachment 8400721 [details] [diff] [review]
>     nightly mozconfig tweaks

I am going to flag the build experts(aki,catlee) here to confirm the mozconfig changes are ok to uplift this on aurora.
Flags: needinfo?(catlee)
Flags: needinfo?(aki)
As mentioned in IRC, b2g mozconfigs shouldn't be an issue.  The mobile and desktop mozconfigs can be problematic for releases if the release mozconfigs aren't updated as well.
Flags: needinfo?(catlee)
Flags: needinfo?(aki)
We only modify b2g nightly mozconfigs:
  /config/mozconfigs/win32_gecko/nightly
  /config/mozconfigs/linux32_gecko/nightly
  /config/mozconfigs/linux64_gecko/nightly
(In reply to Aki Sasaki [:aki] from comment #37)
> As mentioned in IRC, b2g mozconfigs shouldn't be an issue.  The mobile and
> desktop mozconfigs can be problematic for releases if the release mozconfigs
> aren't updated as well.

(In reply to Alexandre Poirot (:ochameau) from comment #38)
> We only modify b2g nightly mozconfigs:
>   /config/mozconfigs/win32_gecko/nightly
>   /config/mozconfigs/linux32_gecko/nightly
>   /config/mozconfigs/linux64_gecko/nightly

Thanks ! have had a fun time when we broke the desktop/mobile mozconfigs long long ago, wanted to be safe than sorry :)
:ochameau, approvals on its way.
Attachment #8400713 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/d2ff4210037b
status-b2g-v1.4: --- → fixed
status-b2g-v2.0: --- → fixed
status-firefox30: --- → fixed
status-firefox31: --- → fixed
Flags: needinfo?(praghunath)
Keywords: leave-open
Target Milestone: --- → 1.4 S6 (25apr)
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: