Closed
Bug 976839
Opened 11 years ago
Closed 11 years ago
GonkPermissionService: Grant AID_RADIO access to android.permission.MODIFY_AUDIO_SETTINGS
Categories
(Firefox OS Graveyard :: Vendcom, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v1.3T | --- | fixed |
People
(Reporter: m1, Assigned: m1)
References
Details
(Whiteboard: [caf priority: p2][cr 613691])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
m1
:
review+
|
Details | Diff | Splinter Review |
As of kk-gonk some rild implementations require access to android.permission.MODIFY_AUDIO_SETTINGS to setup the voice channel.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8381784 -
Flags: review?(mwu)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [cr 613691]
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8381784 [details] [diff] [review]
v1
Mind adding a comment for this check? Looks good otherwise.
Attachment #8381784 -
Flags: review?(mwu) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
comment added, carrying forward r+
Attachment #8381784 -
Attachment is obsolete: true
Attachment #8382493 -
Flags: review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8382493 [details] [diff] [review]
0001-Bug-976839-Grant-AID_RADIO-access-to-android.permiss.patch
Review of attachment 8382493 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/gonk/GonkPermission.cpp
@@ +40,5 @@
> +
> + // Some ril implementations need android.permission.MODIFY_AUDIO_SETTINGS
> + if (uid == AID_RADIO &&
> + perm8 == "android.permission.MODIFY_AUDIO_SETTINGS")
> + return true;
nit: add braces
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Dave Hylands [:dhylands] from comment #4)
> nit: add braces
I'm following the existing style in this file.
|
|
Assignee | |
Comment 6•11 years ago
|
||
Try is green (with a dab of unrelated orange) -- https://tbpl.mozilla.org/?tree=Try&rev=d53874a584d3
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
|
||
Comment 10•11 years ago
|
||
|
|
||
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
|
||
Updated•10 years ago
|
Whiteboard: [cr 613691] → [caf priority: p2][cr 613691]
You need to log in
before you can comment on or make changes to this bug.
Description
•