Closed
Bug 976950
Opened 11 years ago
Closed 10 years ago
Reenable jemalloc and add soname-synonyms when running valgrind on FxOS
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S6 (18july)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: qdot, Assigned: erahm)
References
Details
(Whiteboard: [systemsfe] [p=2])
Attachments
(2 files)
From Mike Hommey on dev.platform:
"[--disable-jemalloc] shouldn't be needed anymore with --soname-synonyms=somalloc=NONE on the valgrind command line."
So we should change our build files and run_valgrind script to reflect this.
|
||
Comment 1•11 years ago
|
||
See also bug 977067!
|
Reporter | |
Comment 2•11 years ago
|
||
Setting dependencies for the moment, but may just end up with this dup'd against Bug 977156 in the end
|
||
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
Vlad, can you try running valgrind+jemalloc with LD_PRELOAD=/system/lib/libc.so? (although i'm not sure if the b2g start script sets or resets LD_PRELOAD)
|
Assignee | |
Comment 5•10 years ago
|
||
I successfully ran valgrind + jemalloc (+ DMD) + b2g.
I modified |gonk-misc/default-gecko-config| to remove |ac_add_options --disable-jemalloc| from the B2G_VALGRIND portion. I then modified |run-valgrind.sh| with the config from bug 977067 comment 29 and managed to get a session going.
|
|
Assignee | |
Comment 6•10 years ago
|
||
This removes the --disable-jemalloc flag from valgrind build..
Attachment #8452832 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
|
||
Updated•10 years ago
|
Attachment #8452832 -
Flags: review?(mh+mozilla) → review+
|
|
Reporter | |
Comment 8•10 years ago
|
||
Comment on attachment 8452834 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/365
See comments on github, I think one of the paths is missing a slash. Other than that, looks good.
Attachment #8452834 -
Flags: review?(kyle) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #8)
> Comment on attachment 8452834 [details]
> Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/365
>
> See comments on github, I think one of the paths is missing a slash. Other
> than that, looks good.
Updated the PR with the missing '/'.
Keywords: checkin-needed
|
||
Comment 10•10 years ago
|
||
gonk-misc/master: https://github.com/mozilla-b2g/gonk-misc/commit/9ff55cd0aefea23e4c60e5844c155c6ebc2e632b
B2G/master: https://github.com/mozilla-b2g/B2G/commit/f194c9ac76633d860033c3d86eab62a9610f153a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
You need to log in
before you can comment on or make changes to this bug.
Description
•