Closed Bug 977145 Opened 11 years ago Closed 11 years ago

[dialer] Make AM/PM localizable when displaying clock

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S3 (14mar)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

(Keywords: l12y)

Attachments

(1 file)

Pull request on Github
(deleted), text/x-github-pull-request
steveck
: review+
Details
Similar to bug 976966, AM|PM is currently hard-coded. Some locales need to both localize those strings (bug 932270) and to display them before the time ("%p %I:%M"). Waiting for bug 976966 to proceed, since the approach should be similar and code is almost identical.
Summary: [dialer] Make AM/PM localizable when displaying lock screen → [dialer] Make AM/PM localizable when displaying clock
Attached file Pull request on Github (deleted) —
Same approach of the bug for system/lockscreen. Discussion in https://github.com/mozilla-b2g/gaia/pull/16664 could be useful to understand some of the choices One test is failing in marionette but it should be unrelated https://travis-ci.org/mozilla-b2g/gaia/builds/19905869 >) Install bookmark on homescreen > Navigate to sample.html and bookmark it on homescreen "before each" hook:
Attachment #8384231 - Flags: review?(etienne)
Assignee: nobody → francesco.lodolo
Requesting 1.4?, since it's the same problem of localizability addressed in in bug 976966, which is already 1.4+.
blocking-b2g: --- → 1.4?
Comment on attachment 8384231 [details] Pull request on Github Redirecting to Tim since I'm not familiar enough with this part of the code.
Attachment #8384231 - Flags: review?(etienne) → review?(timdream)
Blocking for consistency.
blocking-b2g: 1.4? → 1.4+
Attachment #8384231 - Flags: review?(timdream) → review?(schung)
Comment on attachment 8384231 [details] Pull request on Github r=me and thanks for remenbering the incoming call screen also need this fixing.
Attachment #8384231 - Flags: review?(schung) → review+
Thanks. Trying rebase and push to check if Travis is still green before setting checkin-needed This was the previous green run https://travis-ci.org/mozilla-b2g/gaia/builds/20193143
Keywords: l12y
This has conflicts that need rebasing.
Keywords: checkin-needed
Keywords: checkin-needed
I rebased and pushed but I didn't have any conflicts.
Master: fa55023e58fa6649fa1806ba0dc6183d5ec6d66a
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v1.4: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: