Closed
Bug 977153
Opened 11 years ago
Closed 10 years ago
use WITHOUT ROWID in bookmarks roots table
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mak, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
feedback+
|
Details | Diff | Splinter Review |
would even be better to completely kill the table, but that may be a little bit more complex.
ALTER TABLE moz_bookmarks_roots RENAME TO moz_bookmarks_roots_old
CREATE TABLE moz_bookmarks_roots (
root_name TEXT PRIMARY KEY,
folder_id INTEGER
) WITHOUT ROWID
INSERT INTO moz_bookmarks_roots SELECT root_name, folder_id FROM moz_bookmarks_roots_old
DROP TABLE moz_bookmarks_roots_old
|
Reporter | |
Updated•11 years ago
|
Blocks: PlacesDiet
|
||
Updated•11 years ago
|
Blocks: fxdesktopbacklog
|
|
||
Updated•10 years ago
|
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8467825 [details] [diff] [review]
bug977153_without_rowid_bookmark_roots.diff v1
Review of attachment 8467825 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/places/Database.cpp
@@ +1999,5 @@
> + rv = mMainConn->CreateStatement(NS_LITERAL_CSTRING(
> + "SELECT id FROM moz_bookmarks_roots"
> + ), getter_AddRefs(bookmarksRootsStmt));
> +
> + if (!NS_FAILED(rv)) {
NS_SUCCEEDED
Attachment #8467825 -
Flags: feedback?(mak77) → feedback+
|
|
||
Updated•10 years ago
|
Points: --- → 3
Flags: qe-verify?
Whiteboard: p=3
|
|
Reporter | |
Comment 3•10 years ago
|
||
we will remove the table instead.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•