Console filter buttons, (Net, CSS, JS, etc) so not have a visible checked state in screen readers. They should have the aria-checked attribute set when enabled.

(going to p2 some of the accessibility-related bugs and mentor anyone who wants to help with fixing these bugs)

I'm interested in picking this up. (I've got the source code and have started digging through it to see what it all means)

Two things: 1) The console buttons act a lot like toggle buttons, so I've used aria-pressed instead of aria-checked. 2) I've found the relevant code in browser/webtools/webconsole/webconsole.js and built with my changes, but when I try testing it with VoiceOver, I only get "x button". I don't get any "checked/selected/pressed", etc state. This is with any of aria-checked/aria-pressed/aria-selected -- so I'm not sure I've got it working as intended yet. I'm uploading the patch anyway for feedback, maybe someone can point me in the right direction.

(In reply to Athena from comment #3) > 1) The console buttons act a lot like toggle buttons, so I've used > aria-pressed instead of aria-checked. This sounds correct! > 2) I've found the relevant code in browser/webtools/webconsole/webconsole.js > and built with my changes, but when I try testing it with VoiceOver, I only > get "x button". I don't get any "checked/selected/pressed", etc state. This > is with any of aria-checked/aria-pressed/aria-selected -- so I'm not sure > I've got it working as intended yet. I will build with your patch and try this on Windows in a short while! You may be running into either, or a combination, of two issues: a) Either we don't expose this on Mac correctly, since our implementation of NSAccessibility on OS X is not complete, or b) VoiceOver does not support toggle buttons well in general. Again, I will test this on Windows where I know the toggle button implementation is solid, and will let you know! Thank you for working on this!

Comment on attachment 8449227 [details] [diff] [review] aria-checked-console-buttons.patch Athena, your patch is correct. However, it uncovered another bug we have in the accessibility code, and that is that the "pressed" state is not exposed on XUL menu buttons. I will file a dependent bug for that. But your patch definitely fixes the problem from the WebConsole end of things. Note that this is not a formal review, it is just my feedback reply. A web developer tools peer must review this patch formally.

Comment on attachment 8449227 [details] [diff] [review] aria-checked-console-buttons.patch Review of attachment 8449227 [details] [diff] [review]: ----------------------------------------------------------------- this looks good to me. Thanks for doing this.