Closed Bug 977479 Opened 11 years ago Closed 11 years ago

updateUpStream function in NetworkService.js doesn't work

Categories

(Firefox OS Graveyard :: Wifi, defect)

Product:
Firefox OS Graveyard
Component:
Wifi
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S2 (28feb)
Project Flags:
blocking-b2g 1.3T+
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: dimi, Assigned: dimi)

Details

Attachments

(2 files, 2 obsolete files)

fix for bug 977479 v3
(deleted), patch
vchang
: review+
Details | Diff | Splinter Review
Bug 977479 fix for 1.3t
(deleted), patch
Details | Diff | Splinter Review 
updateUpStream function in NetworkService.js doesn't work

root cause:
parameter in NetworkService.js doesn't sync NetworkOption.webidl
Attached patch fix for bug 977479 (obsolete) (deleted) — — Splinter Review 

  

  



    
  

        Attachment #8382778 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix for bug 977479 v2 (obsolete) (deleted)
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #8382792 -
        Flags: review?(vchang)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix for bug 977479 v3 (deleted)
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #8382830 -
        Flags: review?(vchang)

    
  

        Attachment #8382792 -
        Attachment is obsolete: true

        Attachment #8382792 -
        Flags: review?(vchang)

    
    

    
  
Comment on attachment 8382830 [details] [diff] [review]
fix for bug 977479 v3

Review of attachment 8382830 [details] [diff] [review]:
-----------------------------------------------------------------

I have verified this patch using my unagi, it works fine. Thank you.

  

  



        Attachment #8382830 -
        Flags: review?(vchang) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Bug 977479 fix for 1.3t (deleted)
        — 
          — Splinter Review
      

    


  

  

  



    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1337df57a282

  

  


Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)

    
    

    
  
This should apply to 1.3T branch. It' the regression for rewrite net_worker to c++ patch.

  

  


blocking-b2g: --- → 1.3T?
blocking-b2g: 1.3T? → 1.3T+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: