Paul Silaghi, QA [:pauly] Reporter
	Description • 11 years ago

STR:
1. Set Flash to 'Ask to Activate'
2. Open any of the testcases from http://www.w3schools.com/html/html_youtube.asp

AR: There is no 'Activate' text over the plugin content

This appeared first time in nightly 30.0a1 (2014-02-26), so it's a regression of bug 968762 or bug 921730

	Elbart
	Comment 1 • 11 years ago

Regression window: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8c1eb349d342&tochange=b43455151bca

It's probably bug 968762.

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 2 • 11 years ago

So, this seems to be just my oversight of using |defaultView.top| instead of just |defaultView| here.
Obviously we are missing iframe CTP test coverage, fix & test probably coming up tomorrow.

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 3 • 11 years ago

(In reply to Georg Fritzsche [:gfritzsche] from comment #2)
> So, this seems to be just my oversight of using |defaultView.top| instead of
> just |defaultView| here.

... where "here" is:
http://hg.mozilla.org/integration/mozilla-inbound/diff/6d1aabc16a1b/browser/base/content/browser-plugins.js#l1.12

Thanks for the regression window Elbart, that was helpful.

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 5 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=d5e65171fcd9

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a707e35b8524

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/a707e35b8524

	Paul Silaghi, QA [:pauly] Reporter
	Comment 8 • 11 years ago

Verified fixed 30.0a1 (2014-03-07), win 7, ubuntu 13.04 and mac os x 10.9

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 9 • 11 years ago

Comment on attachment 8383585 [details] [diff] [review]
Fix overlay visibilty check, add iframe CTP test coverage

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 968762

User impact if declined: Plugin overlays (like click-to-play, crash, ...) not visible at all if they are in iframes (as e.g. used for video embedding).

Testing completed (on m-c, etc.): More test-coverage, baked & verified on m-c.

Risk to taking this patch (and alternatives if risky): Low. Small, obvious change & added more test coverage.

String or IDL/UUID changes made by this patch: none.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 11 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/28fe2c978d7b