Closed Bug 97821 Opened 23 years ago Closed 12 years ago

Activation component should only be loaded when needed

Categories

(Core Graveyard :: Profile: BackEnd, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE
Future

People

(Reporter: ccarlen, Assigned: ccarlen)

References

Details

Attachments

(1 file, 1 obsolete file)

This was moved from bugscape 8046. For that bug, changes are required in both mozilla and ns. Sanitized comments from that bug: ------- Additional Comments From Conrad Carlen 2001-08-23 18:18 ------- The patch to mozilla/profile includes the patch for bug 66833 because it's needed in order to do this. What it does is this: * Profile mgr front end no longer sets the current profile - it just returns the name of the chosen profile in a string to the backend which actuallys set the profile. This was needed so that the check for activation could be put into nsProfile::SetCurrentProfile and so the profile mgr dialog was disposed of before SetCurrentProfile led to opening the activation window. The patch to activation works like this: * nsIProfileStartupListener and category manager are no longer used. Instead, nsIProfileChangeStatus is used. * The nsIURIContentListener that activation implemented is no longer needed. The docshell no longer needs or uses this content listener mechanism. * Not having to get the docshell out of the activation window so this content listener could be hooked up to it means that windowwatcher could be used to pose the activation window. The benefit here is that the activation component can pass itself as a param into the window.open. This saves having to create a duplicate instance of the component in the front end, which was being done before. ------- Additional Comments From Conrad Carlen 2001-08-27 14:57 ------- Bhuvan, Can you review this? Jud, can you review the removal of the content listener from activation? Hyatt, can you sr? ------- Additional Comments From Jud Valeski 2001-08-27 15:12 ------- r=valeski on the activation mods. ------- Additional Comments From Daniel Veditz 2001-08-28 13:28 ------- sr=dveditz on the activation (commercial) mods, r=dveditz for the mozilla profile mods ------- Additional Comments From racham@netscape.com 2001-08-28 13:42 ------- Changes look good. r=bhuvan. Conrad, There is one issue that I want to bring up. With these patches, we are bringing code for creating the activation component back into the mozilla tree. I know it's going to fail in case of mozilla. But, can we get around not having it..? thanks. ------- Additional Comments From Conrad Carlen 2001-08-30 16:03 ------- This has sr=hyatt (from email)
Attached patch patch to profile mgr (obsolete) (deleted) — Splinter Review
Depends on bugscape 8046
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.4
Get this done today, and we'll consider taking it - - PDT. Moving to 0.9.5
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Depends on: 99566
-> 0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Mass move to 0.9.7
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Attached patch updated patch (deleted) — Splinter Review
Since the bug which is blocking this is close to being fixed, revisiting this. The updated patch hs no real changes, just brought up to date because of changes to the patched code in the meanwhile.
Attachment #47837 - Attachment is obsolete: true
since gain is so small, -> 0.9.9
Target Milestone: mozilla0.9.7 → mozilla0.9.9
improvement was pretty moot per phone call w/ conrad.
Target Milestone: mozilla0.9.9 → Future
QA Contact: ktrina → profile-manager-backend
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: