Closed
Bug 978275
Opened 11 years ago
Closed 11 years ago
FxA Test App - dismiss overlay after a while
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(b2g-v1.4 fixed)
RESOLVED
FIXED
1.4 S3 (14mar)
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
Attachments
(1 file)
Right now, if the FxA Test App fails to getAccounts, the overlay never goes away, and you have to kill the app and reopen. This is annoying, because when you set debugger breakpoints, those are all lost when the app is closed.
So: on Overlay.show(), set a generous timer (2 sec maybe) that calls Overlay.hide(), just in case.
|
Assignee | |
Comment 1•11 years ago
|
||
Really minor thing, but it bothers me every time the test app overlay hangs open forever.
I'm not personally a fan of no-brackets conditional statements, but did it in keeping with the style elsewhere in the file.
Attachment #8383955 -
Flags: review?(ferjmoreno)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8383955 [details]
Github pull request 16753
Use brackets in the conditional statements, please.
Attachment #8383955 -
Flags: review?(ferjmoreno) → review+
|
|
||
Updated•11 years ago
|
Component: Gaia → FxA
Flags: in-moztrap-
|
|
Assignee | |
Comment 3•11 years ago
|
||
ferjm: updated the patch with brackets. anything else I need to do? I haven't gotten to this part of the review cycle before ;-P
Flags: needinfo?(ferjmoreno)
|
|
||
Comment 4•11 years ago
|
||
Heh, after getting the r+ and adding the requested changes to the PR, you can just merge the patch (if Travis is green) or set the checkin-needed flag, so anyone with merge permissions can do it for you.
Flags: needinfo?(ferjmoreno)
|
|
||
Comment 5•11 years ago
|
||
Add r=ferjm to the commit message, please. I'll merge the patch after that. Thanks!
|
|
Assignee | |
Comment 6•11 years ago
|
||
sweet. thanks for the explanation :-)
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•