Closed Bug 978433 Opened 11 years ago Closed 11 years ago

Fix intermittent SIM tests

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 977337

People

(Reporter: kgrandon, Unassigned)

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
Details
Both the one sim and two sim tests are intermittently failing, this bug tracks re-enabling them.

My money is on the fact that we use setTimeout here, and we probably shouldn't be.

Example travis log:

 1) [communications-dialer] navigation bar CallHandler > missed call notification > Two SIMs:

Error: timeout of 10000ms exceeded

at (anonymous) (http://communications.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3680:9)
Tests have been disabled in: https://github.com/mozilla-b2g/gaia/commit/f6f235115b4492df817da32db0042b596181d595
No longer blocks: 978104
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Attached file Pull Request (deleted) —
I am pretty sure there was a race condition with setTimeout and postMessage as postMessage is asynchronous, and the code within the setTimeout required the postMessage handler to complete first. I think we can solve this by doing setTimeout after the postMessage handler has fired.

Running a large job on travis to verify now.
Comment on attachment 8384111 [details]
Pull Request

Anthony - pretty sure this solves the problem, would you want to land this? 

Lots of green runs with this fix: https://travis-ci.org/mozilla-b2g/gaia/builds/19858455
Attachment #8384111 - Flags: review?(anthony)
Attachment #8384111 - Flags: review?(anthony)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: