Closed
Bug 978483
Opened 11 years ago
Closed 11 years ago
Australis: "Sidebars" widget toolbarbutton has not image when it is placed on toolbar on WindowsXP Luna
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Firefox 30
Tracking | Status | |
---|---|---|
firefox29 | --- | unaffected |
firefox30 | - | verified |
People
(Reporter: alice0775, Assigned: mixedpuppy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P3-][aurora29-unaffected])
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Gijs
:
ui-review+
|
Details |
Steps To Reproduce:
1. Enter Customize Mode
2. Move "Sidebar" to toolbar
3. Exit Customize Mode
Actual Results:
"Sidebar" widget toolbarbutton is empty
(About unnecessary scrollbar, I will file a separate bug)
Reporter | ||
Updated•11 years ago
|
Summary: Australis: "Sidebar" widget toolbarbutton has not image when it is placed on toolbar → Australis: "Sidebar" widget toolbarbutton has not image when it is placed on toolbar on WindowsXP Luna
Reporter | ||
Updated•11 years ago
|
Summary: Australis: "Sidebar" widget toolbarbutton has not image when it is placed on toolbar on WindowsXP Luna → Australis: "Sidebars" widget toolbarbutton has not image when it is placed on toolbar on WindowsXP Luna
Updated•11 years ago
|
Whiteboard: [Australis:P3-][aurora-unaffected]
Comment 1•11 years ago
|
||
Duping because the other bug has slightly more info and it's essentially the same issue.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Updated•11 years ago
|
tracking-firefox30:
? → ---
Reporter | ||
Comment 2•11 years ago
|
||
This problem re-appears on
https://hg.mozilla.org/mozilla-central/rev/44ae8462d6ab
Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140312030201
Updated•11 years ago
|
Whiteboard: [Australis:P3-][aurora-unaffected] → [Australis:P3-][aurora29-unaffected]
Updated•11 years ago
|
status-firefox29:
--- → unaffected
Comment 3•11 years ago
|
||
(In reply to Alice0775 White from comment #2)
> This problem re-appears on
> https://hg.mozilla.org/mozilla-central/rev/44ae8462d6ab
> Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0
> ID:20140312030201
The scrollbars as well, or just the icon?
Flags: needinfo?(alice0775)
Comment 5•11 years ago
|
||
This file :
http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/Toolbar-XP.png
is missing the sidebar icon.
Comment 6•11 years ago
|
||
Note that the backed out patch in bug 960198 had the Toolbar-XP.png icons packaged as Toolbar.png .
Comment 7•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #6)
> Note that the backed out patch in bug 960198 had the Toolbar-XP.png icons
> packaged as Toolbar.png .
Here's the file for reference : http://hg.mozilla.org/mozilla-central/raw-file/29c4b76e7364/browser/themes/windows/Toolbar.png
Assignee | ||
Comment 8•11 years ago
|
||
actual image will also be attached
Assignee: nobody → mixedpuppy
Attachment #8390110 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #8390111 -
Flags: ui-review?(gijskruitbosch+bugs)
Comment 10•11 years ago
|
||
Comment on attachment 8390110 [details] [diff] [review]
Toolbar-XP.png patch
Review of attachment 8390110 [details] [diff] [review]:
-----------------------------------------------------------------
Assuming this was chucked through an image optimizer appropriately, r=me
Attachment #8390110 -
Flags: review?(gijskruitbosch+bugs) → review+
Updated•11 years ago
|
Attachment #8390111 -
Flags: ui-review?(gijskruitbosch+bugs) → ui-review+
Assignee | ||
Comment 11•11 years ago
|
||
Comment 12•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Updated•11 years ago
|
Comment 13•11 years ago
|
||
I was able to confirm the fix for this bug on Windows XP 64-bit [1], using Firefox 30 Beta 2 (Build ID: 20140505140302).
[1] Mozilla/5.0 (Windows NT 5.2; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
You need to log in
before you can comment on or make changes to this bug.
Description
•