Closed
Bug 978498
Opened 11 years ago
Closed 11 years ago
SharedArrayBuffer(ARM, x86): align the start of the data to a page boundary, and fix a memory leak.
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: dougc, Assigned: dougc)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
For the ARM and x86, the data or elements of a SharedArrayBuffer could be easily aligned to a page boundary. This might be a prudent constraint to implement now. It will be needed for the buffer.discard() feature in bug 855669, and could alternatively be bundled in there.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → dtc-moz
Attachment #8384194 -
Flags: review?(sstangl)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8384194 [details] [diff] [review]
Align the start of the data to a page boundary, and fix a memory leak.
Review of attachment 8384194 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/vm/SharedArrayObject.cpp
@@ +120,3 @@
> UnmapMemory(p, AsmJSMappedSize);
> #else
> + UnmapMemory(p, this->length + AsmJSPageSize);
Good catch!
Attachment #8384194 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Summary: SharedArrayBuffer(ARM, x86): align the start of the data to a page boundary. → SharedArrayBuffer(ARM, x86): align the start of the data to a page boundary, and fix a memory leak.
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•