I wonder why anyone with bug edit rights can edit patches. That's that harm the backlog and possibly infrige the copyright even? I wouldn't want my patches to be edited by others in a way that my opriginal patch isn't clearly seens anymore. Using this bug to test it.

.

Comment on attachment 47898 [details] [diff] [review] ethzrtz hm, the "Edit Attachment As Comment" button doesn't work for me. Maybe because I don't have XMLextras? Bugzilla shouldn't depend on that. What happened, if I did? Would the edited pacth the added to the bug as Comment, in the body? This desperately needs documentation. Checking "needs-work" :-P

"Edit" is a misnomer. You are actually editing the database record of the attachment, not the attachment itself. When you "Edit Attachment as Comment" you get a textarea containing the content of the attachment *to use in constructing a comment*. In neither case do you get to edit the content of the attachment in the database; this cannot be done. Problems using "Edit Attachment as Comment" should go under bug 97825. Problems with the use of the word "Edit" to describe editing the database record of the attachment should go under a new bug, or perhaps this bug should be converted into that bug.

> Problems > with the use of the word "Edit" to describe editing the database record of the > attachment should go under a new bug, or perhaps this bug should be converted > into that bug. Your call.

Turning this into a bug on changing the name of the "edit" action to something else that makes more sense. The best candidate I have heard so far is "Manage". Any others?

I'll throw in "Edit Status" and "Review", though I too lean toward "Manage". Not that I actually *like* "manage", I hope someone gets a visit from the inspiration fairy.

We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.

Reconsider for 2.16.

This bug is trivial to fix once we decide on a wording. Is "Manage" so much better than "Edit" that it is worth it to change? I personally am sitting on the fence on this issue. What I would *really* like is something even better. "Review" and "edit status" both describe aspects of attachment record editing/management but are not all-encompassing. Any others?

I think it is worthwhile to change to Manage. Manage doesn't really say anything, but it is better to be vague than misleading, and I think manage is less misleading. Other possibilities are "Edit Info", "Handle", "Manipulate", "Process", "Control" and "Administer".

Hmm, either "Manage" or "Edit Info" works for me. I'm leaning towards "Manage".

Although necessary, this will be a temporarily confusing change for users, but it would be less confusing if wrapped up with the overhaul to the "edit attachment" page itself, so setting dependencies appropriately.

Shouldn't this be 2.18 if it depends on a 2.18 bug?

Yes.

All 2.18 bugs that haven't been touched in over 60 days and aren't flagged as blockers are getting pushed out to 2.20

This bug has not been touched by its owner in over six months, even though it is targeted to 2.20, for which the freeze is 10 days away. Unsetting the target milestone, on the assumption that nobody is actually working on it or has any plans to soon. If you are the owner, and you plan to work on the bug, please give it a real target milestone. If you are the owner, and you do *not* plan to work on it, please reassign it to nobody@bugzilla.org or a .bugs component owner. If you are *anybody*, and you get this comment, and *you* plan to work on the bug, please reassign it to yourself if you have the ability.

*** Bug 326927 has been marked as a duplicate of this bug. ***

Comment on attachment 211622 [details] [diff] [review] Manage Personally, I would prefer "Edit properties" than "Manage". I will let myk decide.

LpSolit: myk resigned as ui module owner. i don't want to play games. Justdave leaned toward manage. i took it. let's not mess around. these games aren't acceptable.

myk is not the UI module anymore, but he is still a reviewer. He commented several times in this bug, so he looks like to be more interested in this bug than I am. /me is not playing.

I'd prefer "Edit Info." I think "Manage" would be confusing. It's too ambiguous of a word.

Comment on attachment 211653 [details] [diff] [review] Details Yeah, looks fine to me. r=mkanat by inspection

I've removed "it" from "while viewing its details it " upon checkin. Checking in template/en/default/attachment/created.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/created.html.tmpl,v <-- created.html.tmpl new revision: 1.11.2.1; previous revision: 1.11 done Checking in template/en/default/attachment/diff-header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v <-- diff-header.html.tmpl new revision: 1.12.2.1; previous revision: 1.12 done Checking in template/en/default/attachment/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.30.2.1; previous revision: 1.30 done Checking in template/en/default/attachment/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v <-- list.html.tmpl new revision: 1.25.2.1; previous revision: 1.25 done Checking in template/en/default/attachment/show-multiple.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v <-- show-multiple.html.tmpl new revision: 1.15.12.1; previous revision: 1.15 done Checking in template/en/default/attachment/created.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/created.html.tmpl,v <-- created.html.tmpl new revision: 1.12; previous revision: 1.11 done Checking in template/en/default/attachment/diff-header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v <-- diff-header.html.tmpl new revision: 1.13; previous revision: 1.12 done Checking in template/en/default/attachment/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.31; previous revision: 1.30 done Checking in template/en/default/attachment/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v <-- list.html.tmpl new revision: 1.26; previous revision: 1.25 done Checking in template/en/default/attachment/show-multiple.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v <-- show-multiple.html.tmpl new revision: 1.16; previous revision: 1.15 done