Closed Bug 979169 Opened 11 years ago Closed 9 years ago

[B2G] [Emulator] changing modem tech by "modem tech cdma cdma" fails

Categories

(Firefox OS Graveyard :: Emulator, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: hsinyi, Assigned: bhsu)

References

Details

Attachments

(3 files, 2 obsolete files)

With emulator in gsm mode, it fails in changing modem tech to cdma by the console command "modem tech cdma cdma." But the command "modem tech cdma cdma/evdo" works fine.
Summary: [B2G] [Emulator] change modem tech by "modem tech cdma cdma" fails → [B2G] [Emulator] changing modem tech by "modem tech cdma cdma" fails
Assignee: nobody → htsai
Attached file PR to external/qemu (obsolete) (deleted) —
Attachment #8385174 - Flags: review?(echen)
Comment on attachment 8385174 [details] PR to external/qemu Thank you for catching this.
Attachment #8385174 - Flags: review?(echen) → review+
Blocks: 891707
Attached patch A new testcase (obsolete) (deleted) — Splinter Review
Attachment #8611119 - Flags: review?(szchen)
Comment on attachment 8611119 [details] [diff] [review] A new testcase Review of attachment 8611119 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments ::: dom/telephony/test/marionette/head.js @@ +1151,5 @@ > */ > > this.gDelay = delay; > this.gWaitForSystemMessage = waitForSystemMessage; > + this.gChangeModemTech = changeModemTech; Please put this line in a proper position. I don't have a strong preference, but insert it between two gWaitFor* is kind of wierd. ::: dom/telephony/test/marionette/test_modem_switch_tech.js @@ +7,5 @@ > +startTest(function() { > + return Promise.resolve() > + > + // "gsm/wcdma" > + .then(() => gChangeModemTech("gsm", "gsm/wcdma")) We can simply have an array for all the [(tech, preference), ...]. Then use a for loop to iterate it.
Attachment #8611119 - Flags: review?(szchen) → review+
Attached patch A new testcase. r=aknow (deleted) — Splinter Review
Attachment #8611119 - Attachment is obsolete: true
Attachment #8613369 - Flags: review+
Ben is actively working on this. Set him as assignee. Thanks, Ben.
Assignee: htsai → bhsu
Simply rebasing Hsinyi's work
Attachment #8614557 - Flags: review+
Simply rebasing Hsinyi's work
Attachment #8614559 - Flags: review+
Attachment #8385174 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: