Georg Fritzsche [:gfritzsche] Reporter
	Description • 11 years ago

      No description provided.

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 1 • 11 years ago

In some cases we still layer the plugin overlay on top after bug 976769.

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 2 • 11 years ago

This stops the overlay being on top at the URL, but still has problems with the closeIcon. No value for position is helpful here:
* relative: closeIcon still over menu
* absolute: closeIcon at top right of page
* remove position specification: can't get closeIcon positioned using top and right

jaws, do you have an idea on what's going on here or a better option?

	Benjamin Smedberg
	Comment 5 • 11 years ago

Any positioned content creates its own stacking context, so anything that uses relative or absolute positioning will then be positioned over DOM nodes that are earlier in the tree but also have stacking contexts. We could try making it less common by giving things a *negative* z-index, but I'm not sure that won't introduce other issues.

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 6 • 11 years ago

Comment on attachment 8385366 [details] [diff] [review]
WIP

Yeah, I don't know what we can realistically do here. I actually think it is best how it is currently working, since we have the close icon the user can get rid of it.

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 7 • 11 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> I actually think it is
> best how it is currently working, since we have the close icon the user can
> get rid of it.

Well, per the changes in bug 853973 we only hide the overlay contents, not the overlay itself - .mainBox & .visible handling here:
http://hg.mozilla.org//mozilla-central/annotate/e5b09585215f/toolkit/mozapps/plugins/content/pluginProblemContent.css#l61

If we don't want to try to respect the layering in the page, we could also just make the "close overlay" buttons hide the element itself or all of the overlay again.

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 8 • 11 years ago

How about this then? This hides the whole overlay on close icon click, but shows it again when needed (like click-to-play => activate => crash or re-block).

Note:
* also did some cleanup/consolidation while i was there
* will add test if this is acceptable

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 9 • 10 years ago

Sorry for the run around here. This fixes for me the first patch that you posted. What do you think about it?

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 10 • 10 years ago

Sorry, i think i will only get here next week.

	Georg Fritzsche [:gfritzsche] Reporter
	Comment 11 • 10 years ago

Comment on attachment 8394159 [details] [diff] [review]
Patch - Fixed first attempt

Sorry this slipped by for a while.
I'm not confident about evaluating CSS changes, but the behavior seems fine with the URLs in the cluster of bugs here and we do show notification bars for non-visible plugins now.

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 12 • 10 years ago

Comment on attachment 8394159 [details] [diff] [review]
Patch - Fixed first attempt

Review of attachment 8394159 [details] [diff] [review]:
-----------------------------------------------------------------

Gijs, are you comfortable reviewing the CSS changes here?

	:Gijs (he/him)
	Comment 13 • 10 years ago

Comment on attachment 8394159 [details] [diff] [review]
Patch - Fixed first attempt

Review of attachment 8394159 [details] [diff] [review]:
-----------------------------------------------------------------

display: table?

*twitch*

But yeah, this works. Obvious assumption here is that there's no other positioned content relying on that position: relative, which there doesn't seem to be. r=me

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 14 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=6f3516efc267

	:Gijs (he/him)
	Comment 15 • 10 years ago

Note that this makes the text and icon off-center. Adding -moz-margin-start: -20px fixes this. r=me with that. Oops. :-\

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 16 • 10 years ago

Carrying forward r+ from Gijs, with -moz-margin-start rule added.

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 17 • 10 years ago

Marco, can you please add this to the current iteration. This was old work which had been forgotten about in a review queue.

	Marco Mucci [:MarcoM]
	Comment 18 • 10 years ago

Added to Iteration 32.3

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 19 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/fc14c1c42b68

	Carsten Book [:Tomcat]
	Comment 20 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/fc14c1c42b68

	Paul Silaghi, QA [:pauly]
	Comment 21 • 10 years ago

http://oharenoise.org/
http://wiesenmarkt.at/news.php
http://www.eleanorlaing.com/
http://www.huffingtonpost.com/2012/01/09/taiwan-garbage-trucks-music_n_1195020.html#comments
The menu is properly displayed, 32.0a1 (2014-06-04), Win 7 x64, Ubuntu 12.10, OS X 10.8.5