Closed
Bug 979632
Opened 11 years ago
Closed 11 years ago
[OS X] Replace with menu button graphic with the Australis one.
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 30.0
People
(Reporter: jsbruner, Assigned: jsbruner)
Details
Attachments
(1 file)
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
The current menu button we're using on OS X isn't consistent with Australis, but the bigger problem is with the @2x graphic. Our current graphic is very small while on a retina display, the Australis graphic fixes that.
We may want to replace the graphic on other platforms as well, but let's start with OS X.
Assignee | ||
Comment 1•11 years ago
|
||
Comment on attachment 8385728 [details] [diff] [review]
Patch.
Review of attachment 8385728 [details] [diff] [review]:
-----------------------------------------------------------------
I've already looked at this on both a retina and non-retina display, and everything looks fine, but since we need a reviewer...
Richard, could you look this over real quick?
Attachment #8385728 -
Flags: review?(richard.marti)
Comment 2•11 years ago
|
||
Comment on attachment 8385728 [details] [diff] [review]
Patch.
LGTM, thanks Josiah.
Attachment #8385728 -
Flags: review?(richard.marti) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
Comment 4•11 years ago
|
||
Hmm, to late. I planned to propose to optimize the images. I was able to shrink them to 72% and 75% of the actual size.
Assignee | ||
Comment 5•11 years ago
|
||
I went ahead and landed an optimization patch which reduced the file sizes to 16KB and 43KB as opposed to the previous 21KB and 57KB.
https://hg.mozilla.org/comm-central/rev/0264d503ecc7
Comment 6•11 years ago
|
||
Were there plans to update the Windows and Linux menu buttons as well?
Assignee: nobody → josiah
Flags: needinfo?(josiah)
Comment 8•11 years ago
|
||
(In reply to Josiah Bruner [:JosiahOne] from comment #7)
> Yes. But I can't test Windows myself.
I can test it for you, or Paenglab can. Would you mind filing bugs for those other systems?
Assignee | ||
Comment 9•11 years ago
|
||
Sure. Bug 980491.
You need to log in
before you can comment on or make changes to this bug.
Description
•