Comment on attachment 8385789 [details] [diff] [review] Port the per-source flags for skia to moz.build Although these flags show up in backend.mk, they don't end up on the command-line. It looks like this is because you used $($(notdir $<)_FLAGS), so for example 'trunk/src/opts/SkBitmapFilter_opts_SSE2.cpp_FLAGS += ...' in backend.mk doesn't work, but 'SkBitmapFilter_opts_SSE2.cpp_FLAGS += ...' does. Since we need 'trunk/src/opts/...' in the moz.build file to match the SOURCES key, I'd guess you want an os.path.basename() when writing out these flags in the recursive make backend.

(The patch otherwise looks fine, btw).

Comment on attachment 8385789 [details] [diff] [review] Port the per-source flags for skia to moz.build (In reply to Michael Shal [:mshal] from comment #2) > Comment on attachment 8385789 [details] [diff] [review] > Port the per-source flags for skia to moz.build > > Although these flags show up in backend.mk, they don't end up on the > command-line. It looks like this is because you used $($(notdir $<)_FLAGS), > so for example 'trunk/src/opts/SkBitmapFilter_opts_SSE2.cpp_FLAGS += ...' in > backend.mk doesn't work, but 'SkBitmapFilter_opts_SSE2.cpp_FLAGS += ...' > does. > > Since we need 'trunk/src/opts/...' in the moz.build file to match the > SOURCES key, I'd guess you want an os.path.basename() when writing out these > flags in the recursive make backend. Did you see the depdendency, bug 979681? :-) That fix is already on inbound.

Comment on attachment 8385789 [details] [diff] [review] Port the per-source flags for skia to moz.build Nope, I missed that :(. Sorry!