Closed
Bug 979785
Opened 11 years ago
Closed 11 years ago
[GAIA][BUILD SYSTEM] Overwrite common-setting.json by GAIA_DEVICE_TYPE in build/settings.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: GaryChen, Assigned: GaryChen)
References
Details
Attachments
(1 file)
Difference devices may have different settings value, we need to create new method overwrite common-setting.json in build/settings.js
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gchen
Assignee | ||
Updated•11 years ago
|
Component: Gaia → Gaia::Build
Assignee | ||
Comment 2•11 years ago
|
||
Hi Yuren, Can you help to review this patch and give me some feedback? Thanks.
Attachment #8417882 -
Flags: review?(yurenju.mozilla)
Comment 3•11 years ago
|
||
Comment on attachment 8417882 [details] pull request: https://github.com/mozilla-b2g/gaia/pull/18974 we should use |GAIA_DEVICE_TYPE| to assemble the file path what you need in js, please see comment on github.
Attachment #8417882 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8417882 [details] pull request: https://github.com/mozilla-b2g/gaia/pull/18974 Hi Yuren, I've addressed your comment, please help to review this patch again.
Attachment #8417882 -
Flags: review?(yurenju.mozilla)
Comment 5•11 years ago
|
||
Comment on attachment 8417882 [details] pull request: https://github.com/mozilla-b2g/gaia/pull/18974 looks good, r=yurenju.
Attachment #8417882 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 6•11 years ago
|
||
travis green: https://travis-ci.org/mozilla-b2g/gaia/builds/24962717 land in master: https://github.com/mpizza/gaia/commit/230ee3a4f57b875da803c68dbd0bca227b1d2f4f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•