Martin Stránský [:stransky] (ni? me) Assignee
	Description • 10 years ago

downstream bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1056313
https://bugzilla.redhat.com/show_bug.cgi?id=1070741

It's caused by:

expose_event(cairo_t* cr)

[...]

cairo_surface_t *surf = cairo_get_target(cr);

[...]

mThebesSurface = gfxASurface::Wrap(surf);

where cr/surf (obtained from gtk) are the same even when the window itself is resized. The result is that gfxASurface::Wrap() does not create a new mThebesSurface surface but keeps to return the first, original one, with old size buffered.

	Karl Tomlinson (:karlt)
	Comment 2 • 10 years ago

Comment on attachment 8386088 [details] [diff] [review]
patch

gfxXlibSurface(cairo_surface_t*) should not be used like this.
(This constructor should really not be public, so as to prevent this.)
Each of the wrapper gfxXlibSurface surfaces will not be deleted until the cairo_surface_t is destroyed, and so they leak.

Perhaps the simplest solution is to remove mSize from gfxXlibSurface and make GetSize() call cairo_xlib_surface_get_width/height() each time.
(If don't think that would be a performance problem.)

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 3 • 10 years ago

Thanks! There's the updated one. It also fixes a build warning when cairo_gdk_drawable_key is not used in gtk3 code.

	Karl Tomlinson (:karlt)
	Comment 4 • 10 years ago

Comment on attachment 8386739 [details] [diff] [review]
patch v.2

Looks good to me thanks.
Better check that Jeff is happy with this.

	Emilio Pozuelo Monfort
	Comment 6 • 10 years ago

This patch fixes the corruption I mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=624422#c48

	Karl Tomlinson (:karlt)
	Comment 7 • 10 years ago

Comment on attachment 8386739 [details] [diff] [review]
patch v.2

Feel free to land this, once it has a better checkin comment.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 8 • 10 years ago

Thanks! Try build: https://tbpl.mozilla.org/?tree=Try&rev=dcc3969bb1cf

	Carsten Book [:Tomcat]
	Comment 10 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d346d2c6f88

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/3d346d2c6f88