Closed Bug 980030 Opened 11 years ago Closed 8 years ago

Use a real time thread for b2g sampling

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: BenWa, Unassigned)

References

Details

Results from bug 980027 show promising results. This should improve our sampling accuracy on b2g quite a bit.
Blocks: 980003
I plan to land a fix to GonkHal.cpp to allow RT thread priorities in bug 980027. So this bug depends on that.
Depends on: 980027
Are we talking about "InputReader" thread here or else ? http://dxr.mozilla.org/mozilla-central/source/widget/gonk/nsAppShell.cpp#961
(In reply to Vincent Lin[:vilin] from comment #2) > Are we talking about "InputReader" thread here or else ? > http://dxr.mozilla.org/mozilla-central/source/widget/gonk/nsAppShell.cpp#961 No, I mean the thread which takes samples: http://mxr.mozilla.org/mozilla-central/source/tools/profiler/platform-linux.cc#261 If a high priority thread is running we wont be able to collect samples because right now the SignalSender is of default priority and therefore get a bad sample when trying to profile it.
This will need child process access to hal::SetCurrentThreadPriority(). This is bug 982325.
Depends on: 982325
B2G
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.