Closed Bug 980096 Opened 11 years ago Closed 11 years ago

MediaEngineWebRTC leaking VoiceEngine references

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: memory-leak, Whiteboard: [lsan][MemShrink])

Attachments

(1 file, 2 obsolete files)

We're leaking a number of VoiceEngine references in MediaEngineWebRTC.cpp and MediaEngineWebRTCAudio.cpp. Some of these go back to the beginning, because of the need to manually call Release(). Note that even with these plugged, we're not reliably releasing the MediaEngineWebRTCAudioSource objects before shutdown of MediaEngine (perhaps they're still ref'd by JS indirectly).
Comment on attachment 8386619 [details] [diff] [review] fix leaks of VoiceEngines in getUserMedia (WIP) first check shows a GUM audio test (gum_test.html) for audio-only leaks ~450K vs ~1.5MB (linux64) with this patch
Attachment #8386619 - Attachment description: fix leaks of VoiceEngines in getUserMedia → fix leaks of VoiceEngines in getUserMedia (WIP)
Attached patch fix leaks of VoiceEngines in getUserMedia (obsolete) (deleted) — Splinter Review
several runs with gUM audio show no leaks in webrtc now; most leaks are coming from spdy and xpcom startup stuff.
Attachment #8386619 - Attachment is obsolete: true
Attachment #8386629 - Attachment is obsolete: true
Attachment #8386691 - Flags: review?(anant)
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [lsan][MemShrink]
Patch is from bug 980304 (r=khuey fold of patch on this bug and followup there) https://hg.mozilla.org/integration/mozilla-inbound/rev/e2ca2e77c0ef
Target Milestone: --- → mozilla30
Attachment #8386691 - Flags: review?(anant)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 986764
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: