Closed
Bug 980192
Opened 11 years ago
Closed 11 years ago
Failed to build B2G emulator-x86, no __NR_sendto, __NR_recvfrom, too many initializers for 'sock_filter'
Categories
(Firefox OS Graveyard :: Emulator, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jld
:
review+
kang
:
review+
|
Details | Diff | Splinter Review |
security/sandbox/linux/Sandbox.cpp:62: error: '__NR_sendto' was not declared in this scope
security/sandbox/linux/Sandbox.cpp:62: error: '__NR_recvfrom' was not declared in this scope
security/sandbox/linux/Sandbox.cpp:68: error: too many initializers for 'sock_filter'
security/sandbox/linux/Sandbox.cpp:68: error: too many initializers for 'sock_filter'
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → vyang
Attachment #8386577 -
Flags: review?(jld)
Attachment #8386577 -
Flags: review?(gdestuynder)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8386577 [details] [diff] [review]
patch
Review of attachment 8386577 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #8386577 -
Flags: review?(jld) → review+
Comment on attachment 8386577 [details] [diff] [review]
patch
Review of attachment 8386577 [details] [diff] [review]:
-----------------------------------------------------------------
if that's changed then its fine to r+
::: security/sandbox/linux/seccomp_filter.h
@@ +111,5 @@
> #define SECCOMP_WHITELIST_ARCH_DESKTOP_LINUX
> #endif
>
> +/* Architecture-specific syscalls for B2G */
> +#if defined(__arm__)
these are defined for x86_64.
i would do instead:
"#if !defined(__i386__)"
or
"#if defined(__arm__) && defined(__x86_64__)"
(or similar)
Note also, that the desktop white list has the same issue.
Attachment #8386577 -
Flags: review?(gdestuynder) → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Address review comments in comment 3. Thank you!
Attachment #8386577 -
Attachment is obsolete: true
Attachment #8389640 -
Flags: review?(jld)
Attachment #8389640 -
Flags: review?(gdestuynder)
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
||
Updated•11 years ago
|
Attachment #8389640 -
Flags: review?(jld) → review+
Attachment #8389640 -
Flags: review?(gdestuynder) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
|
||
Updated•9 years ago
|
Blocks: Emulator_L_Local
|
|
||
Updated•9 years ago
|
No longer blocks: Emulator_L_Local
You need to log in
before you can comment on or make changes to this bug.
Description
•