Closed
Bug 980208
Opened 11 years ago
Closed 11 years ago
[DSDS][Dialer] Call button should display default SIM
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(Not tracked)
VERIFIED
FIXED
1.4 S3 (14mar)
People
(Reporter: drs, Assigned: drs)
References
Details
(Whiteboard: [ucid:, 1.4, ft:comms])
Attachments
(1 file)
See spec.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → drs+bugzilla
Comment 1•11 years ago
|
||
FYI, we need to listen for the setting change to update the button. Also, Julien told me about the idea of using data-attributes and |content: attr()| to display the SIM text. I'm not sure that's useful or easier to code but just mentioning.
Assignee | ||
Comment 2•11 years ago
|
||
Setting blockers based on the spec.
Blocks: b2g-dsds-1.4, 1.4-comms-committed
Whiteboard: [ucid:, 1.4, ft:comms]
Target Milestone: --- → 1.4 S3 (14mar)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8388876 -
Flags: review?(anthony)
Comment 4•11 years ago
|
||
Comment on attachment 8388876 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17044 Don't rely on IDs. We will have more than one call button on some screens (for example, a contact can have more than one number or the dialer has the regular call button + the voicemail long tap). I think this code should live in CallButton. It should only add a class ('has-preferred-sim' maybe?) when we have a preferred SIM (aka not when the setting is always ask) and update the content of the inner element with a 'js-sim-indication' class (that we select with button.querySelector('.js-sim-indication') Then, each screen is responsible to update the UI with something like: .call-button.has-preferred-sim:after { content: ""; background-image: url(images/long-tap-indicator.png); }
Attachment #8388876 -
Flags: review?(anthony) → review-
Comment hidden (spam) |
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8388876 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17044 Updated PR.
Attachment #8388876 -
Flags: review- → review?(anthony)
Assignee | ||
Comment 7•11 years ago
|
||
The spec states that the long tap "..." indicator should go white when a phone number is entered in the dialer, but no white long tap indicator has been provided. I can apply a filter to the given icon, but this seems like overkill. Can you comment on this, Jose?
Flags: needinfo?(vittone)
Assignee | ||
Comment 8•11 years ago
|
||
Also note that I can Photoshop the indicator myself, but I'm asking about this because I might have missed something.
Updated•11 years ago
|
Attachment #8388876 -
Flags: review?(anthony) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/24dbc388ae70a524ff845ae91830781572872bbc Jose: If we still want to do the white long tap indicator, we can do it as a followup to this.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Hi Doug, I build latest code but still send key in dialer still the old one, can you check again? Gaia ec28d9dcf57ca8da142f9f2fea33bc288b76ed59 Gecko 0bacffad36f65a27929ca85164792750c695c3cb BuildID 20140313053055 Version 30.0a1
Flags: needinfo?(drs+bugzilla)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Enpei from comment #10) > Hi Doug, > > I build latest code but still send key in dialer still the old one, can you > check again? > Gaia ec28d9dcf57ca8da142f9f2fea33bc288b76ed59 > Gecko 0bacffad36f65a27929ca85164792750c695c3cb > BuildID 20140313053055 > Version 30.0a1 See bug 946866 comment 52.
Flags: needinfo?(drs+bugzilla)
Comment 12•11 years ago
|
||
Verified on Fugu. Gaia b5d0f9b0cd5dce38b79287a9363226b912929270 Gecko 7312341e00e2785419fc4746e291646299ba3018 BuildID 20140313120331 Version 30.0a1
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Flags: in-testsuite+
Comment 13•11 years ago
|
||
(In reply to Doug Sherk (:drs) from comment #7) > The spec states that the long tap "..." indicator should go white when a > phone number is entered in the dialer, but no white long tap indicator has > been provided. I can apply a filter to the given icon, but this seems like > overkill. Can you comment on this, Jose? Hi Doug, The semi-transparent black icon is just fine, it was specify in that way. https://bug946874.bugzilla.mozilla.org/attachment.cgi?id=8374218 Thanks for asking!
Flags: needinfo?(vittone)
QA Whiteboard: [fxosqa-auto-backlog?]
QA Whiteboard: [fxosqa-auto-backlog?] → [fxosqa-auto-backlog+]
Comment 14•10 years ago
|
||
Hi Geo, I can also help with the auto test case creation.
You need to log in
before you can comment on or make changes to this bug.
Description
•