Closed
Bug 98037
Opened 23 years ago
Closed 23 years ago
Brand new profile, newsgroups requiring auth are coming up 'all read' status.
Categories
(MailNews Core :: Networking: NNTP, defect)
MailNews Core
Networking: NNTP
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.5
People
(Reporter: stephend, Assigned: sspitzer)
References
()
Details
(Whiteboard: fixed on the trunk [QA has verified],PDT+)
Attachments
(3 files)
(deleted),
text/plain
|
Details | |
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
mscott
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
Build ID: 2001-08-31-03, All OSs.
Summary: Brand new profile, news://poisonivy.mcom.com/xrated is coming up with
'all read' status.
Steps to Reproduce:
1. Make sure you have a clean profile, or at least have deleted your news files
(rc, msf, etc)
2. Using poisonivy.mcom.com, subscribe to 'xrated' (an auth group)
3. Enter your authentication info (Seth, if you don't know user/pass, AIM me or
mail me).
4. Get all of the messages in the group (105 at time of this bug report).
Actual Results:
On a brand new profile, all of these postings are marked as read.
Expected Results:
Newsgroup should be totally unread, as it's the first time you've seen it
(according to your profile).
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
This happened even on a migrated 4.7x profile (win32), but doesn't happen on any
other newsgroups... Interesting to note, when you restart Mozilla this usually
gets the right unread counts and status markings back.
Reporter | ||
Comment 3•23 years ago
|
||
Reporter | ||
Comment 4•23 years ago
|
||
The screenshot I posted was after restarting Mozilla, as soon as I clicked on
the newsgroup, the unread count in the folder pane vanished (even though you can
see that the message pane is totally unread). Note that we're also incorrect in
the taskbar/status bar.
When you create new profile are you just exiting from a profile that has same
newsgroup and leaving quick launch open?
Reporter | ||
Comment 7•23 years ago
|
||
John Lar, no quick launch was used, and I just ran mozilla.exe with -
profilemanager to create a brand new profile.
Assignee | ||
Comment 8•23 years ago
|
||
yes, I see this too, and on netscape.champions
both groups require authentication.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
Assignee | ||
Updated•23 years ago
|
Summary: Brand new profile, newsgroup is coming up 'all read' status. → Brand new profile, newsgroups requiring auth are coming up 'all read' status.
Comment 9•23 years ago
|
||
So far, only seeing this on NNTP servers running Netscape-Collabra software. I
log into other NNTP servers NOT running this software and expected read/unread
behaviour is normal.
Comment 10•23 years ago
|
||
Do you read groups that require authentication on those non-Collabra servers?
Comment 11•23 years ago
|
||
Yes Dan, I do log into one particular non-collabra server that requires
authentication and the read/unread anomaly doesn't exist.
Assignee | ||
Comment 12•23 years ago
|
||
part of the problem (there might be more) is that when we update the unread
counts (issuing GROUP commands) we end up setting the read set to include
everything.
I'll continue debugging.
Comment 13•23 years ago
|
||
This sounds pretty bad. I'm chanigng my mind.
Assignee | ||
Comment 14•23 years ago
|
||
wacky, the value in the newsrc looks fine.
I'll continue to debug.
Comment 15•23 years ago
|
||
I've noticed that if you are already authenticated on one group on a given
server (such as netscape.champion.beta), if you subsequently move on to another
auth group (such as netscape.champions) the messages appear marked as UNread.
Just as they should be.
Assignee | ||
Comment 16•23 years ago
|
||
yes, I'm seeing similar weirdness to what steve mann reports.
actually, I do see some newsrc weirdness.
instead of setting the newsrc line to be "1-oldest" we're somehow setting it
to "1-youngest", which makes all articles read. not sure why that's happening
yet.
Assignee | ||
Comment 17•23 years ago
|
||
fix in hand. damn, this bug was a pain to debug.
Assignee | ||
Comment 18•23 years ago
|
||
Assignee | ||
Comment 19•23 years ago
|
||
the problem is I was calling CleanupNewsgroupList() and I didn't need to at
BeginReadXOver().
CleanupNewsgroupList calls FinishXOVERLINE() which will adjust the unread set.
I was smoking the good stuff when I slapped that call to CleanupNewsgroupList()
to release m_newsgroupList. (CleanupNewsgroupList() sets it to null.)
that's not necessary, since we create a new nsINNTPNewsgroupList, which would
cause m_newsgroupList to get released.
cleanup should only be called after we've done work.
Comment 20•23 years ago
|
||
Comment on attachment 50191 [details] [diff] [review]
the fix.
r=mscott
Attachment #50191 -
Flags: review+
Assignee | ||
Comment 21•23 years ago
|
||
Comment on attachment 50191 [details] [diff] [review]
the fix.
this has sr=bienvenu, over aim.
Attachment #50191 -
Flags: superreview+
Assignee | ||
Comment 22•23 years ago
|
||
fixed on the trunk. awaiting verification and then PDT approval for the branch.
stephend, if you have cycles, can you verify this on tomorrow's trunk builds?
Assignee | ||
Updated•23 years ago
|
Whiteboard: fixed on the trunk
Reporter | ||
Comment 23•23 years ago
|
||
Verified FIXED on the trunk:
Mac OS 9.1 - 2001-09-21-04
Windows 2K - 2001-09-21-03
RedHat 7.1 - 2001-09-21-06
I did both migrated 4.7x profiles, and new profiles, and this is indeed FIXED.
Whiteboard: fixed on the trunk → fixed on the trunk [QA has verified]
Comment 24•23 years ago
|
||
check it in - PDT+
Whiteboard: fixed on the trunk [QA has verified] → fixed on the trunk [QA has verified],PDT+
Comment 25•23 years ago
|
||
As of 2001092103 it's fixed. Deleted n.champions, re-subscribed and behaviour is
back to normal. Thanks !!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 26•23 years ago
|
||
This should stay open until Seth lands this on the trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 28•23 years ago
|
||
fixed on both trunk and branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 29•23 years ago
|
||
This has now been VERIFIED FIXED using the latest 9-23-xx BRANCH builds on Mac
OS 9.1, RedHat Linux 7.1 and Windows 2000.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•