The dialer app still uses navigator.mozMobileConnection in a few places including its mock in unit-tests; those uses should be removed and made to rely only on navigator.mozMobileConnections.

Hi Gabriele I like to work on this.Can i get this assigned? Thanks

(In reply to kumar rishav from comment #1) > Hi Gabriele > I like to work on this.Can i get this assigned? A lot of changes here are in the MMI tests which will be rewritten once bug 889737 lands so I don't think it's a good idea to start working on this now. I'm adding the dependency to make this explicit.

Note that some chunks of the dialer app were moved to the new callscreen app in bug 990003 and a stray navigator.mozMobileConnection use was moved there too; that should be removed as part of this bug.

Updated the dependencies, the MMI related parts are gone as part of bug 1002327 but we've still left with two uses one in apps/callscreen/js/calls_handler.js and the other in apps/communications/dialer/js/telephony_helper.js.

Replaced references to mozMobileConnection with mozMobileConnections in the telephony_helper.js and the calls_handler.js

Comment on attachment 8423152 [details] pull request for patch The patch looks good to me, thanks for your work! While looking at the code I noticed that this might actually need a follow-up. The code in the CallsHandler is picking the first SIM card's MCC for the SimplePhoneMatcher irrespective of how many SIMs are in the device: https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/js/calls_handler.js#L19 Etienne, shouldn't this code become DSDS-aware and use the MCC of the current default SIM card? In case do we already have a bug for that?

(In reply to Gabriele Svelto [:gsvelto] from comment #6) > Comment on attachment 8423152 [details] > pull request for patch > > The patch looks good to me, thanks for your work! > > While looking at the code I noticed that this might actually need a > follow-up. The code in the CallsHandler is picking the first SIM card's MCC > for the SimplePhoneMatcher irrespective of how many SIMs are in the device: > > https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/js/ > calls_handler.js#L19 > > Etienne, shouldn't this code become DSDS-aware and use the MCC of the > current default SIM card? In case do we already have a bug for that? In a perfect world the SimplePhoneMatcher should have an array of mcc since it's used to match incoming calls phone numbers and you can get them on both sims :) But yes a follow-up is definitely needed.

Marking this as invalid. Wrong version of the device.

Sorry, wrong defect. Ignore that last change.

Added the checkin-needed flag. There is a failing test due to an intermittent timeout issue. Please see the URL to the Travis build as we have retriggered.

Merged to gaia/master ec9f26124034d0f966a09c41290b1fdb1ce0a7fe https://github.com/mozilla-b2g/gaia/commit/ec9f26124034d0f966a09c41290b1fdb1ce0a7fe