Closed
Bug 980402
Opened 11 years ago
Closed 11 years ago
Remove navigator.mozMobileConnection uses from the homescreen app / everything.me
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gsvelto, Assigned: rishav_, Mentored)
References
Details
(Whiteboard: [lang=javascript])
Attachments
(1 file)
The homescreen app still uses navigator.mozMobileConnection via everything.me:
https://github.com/mozilla-b2g/gaia/blob/0742d628484fcb88d5b9d91942581daaf23fefb9/apps/homescreen/everything.me/js/helpers/Utils.js#L1011
That uses should be removed and the relevant code must be made to rely only on navigator.mozMobileConnections.
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [mentor=:gsvelto][lang=javascript]
|
|
Reporter | |
Updated•11 years ago
|
Blocks: sms-refactoring
|
Assignee | |
Comment 1•11 years ago
|
||
Hi gabriele
Can you have a look on attached PR?.
Thanks
Attachment #8407066 -
Flags: feedback?(gsvelto)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8407066 [details]
Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me
LGTM.
Attachment #8407066 -
Flags: feedback?(gsvelto) → feedback+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Hi gabriele
I did the suggested change.Can you assign this bug to me?
Also Can you Please set the review flag to related peer?
Thanks
|
|
Reporter | |
Comment 4•11 years ago
|
||
(In reply to kumar rishav from comment #3)
> I did the suggested change.Can you assign this bug to me?
Done.
> Also Can you Please set the review flag to related peer?
You have to set the flag yourself, you can find the Homescreen / Everything.me peers on this page:
https://wiki.mozilla.org/Modules/FirefoxOS#Homescreen
Assignee: nobody → rishav006
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8407066 [details]
Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me
Hi crdlc@tid.es
Can you have a look on PR?
Thanks
Attachment #8407066 -
Flags: review?(crdlc)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8407066 [details]
Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me
Good job!, Thanks a lot
Attachment #8407066 -
Flags: review?(crdlc) → review+
|
|
Reporter | |
Comment 7•11 years ago
|
||
Thanks to both, merged to gaia/master a87266f3ddb4f43ac95924faedc0fa445cb3dffd
https://github.com/mozilla-b2g/gaia/commit/a87266f3ddb4f43ac95924faedc0fa445cb3dffd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Mentor: gsvelto
Whiteboard: [mentor=:gsvelto][lang=javascript] → [lang=javascript]
You need to log in
before you can comment on or make changes to this bug.
Description
•