Closed
Bug 980419
Opened 11 years ago
Closed 7 years ago
Preferences should not be allowed to be accessed off of the main thread on b2g.
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: khuey, Assigned: fabrice)
References
Details
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #619487 +++
B2G still needs some love here.
Assignee | ||
Comment 1•11 years ago
|
||
This removes the memory_info_dumper.watch_fifo.directory OMT access.
I still see gfx.apitrace.enabled and gl.msaa-level.
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Attachment #8387901 -
Flags: review?(benjamin)
Updated•11 years ago
|
Attachment #8387901 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → fabrice
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Comment 5•11 years ago
|
||
This bug still requires removing the #ifndef MOZ_B2G conditions in https://hg.mozilla.org/mozilla-central/rev/c50ed2757551 , right?
Flags: needinfo?(khuey)
Flags: needinfo?(fabrice)
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #6)
> (Or do the other 2 from comment 1 still need to be fixed first as well?)
I think so. I should have filed this one as a dependency instead of hijacking the whole bug :(
Flags: needinfo?(fabrice)
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(khuey)
Comment 8•9 years ago
|
||
(In reply to [:fabrice] Fabrice Desré from comment #1)
> Created attachment 8387901 [details] [diff] [review]
> omt-pref-memdump.patch
>
> This removes the memory_info_dumper.watch_fifo.directory OMT access.
>
> I still see gfx.apitrace.enabled and gl.msaa-level.
These off main thread accesses were fixed, but b2g add 'dom.ipc.processPrelaunch.testMode' as off main thread access.
https://dxr.mozilla.org/mozilla-central/source/ipc/glue/MessageLink.cpp#148
The following is a tryserver result.
https://treeherder.mozilla.org/logviewer.html#?job_id=11317921&repo=try
Comment 9•9 years ago
|
||
:cyu, can 'dom.ipc.processPrelaunch.testMode' be changed not to be accessed from off main thread? Bug 977359 add it.
Flags: needinfo?(cyu)
Comment 10•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #9)
> :cyu, can 'dom.ipc.processPrelaunch.testMode' be changed not to be accessed
> from off main thread? Bug 977359 add it.
Yes. I opened bug 1204455 for it.
Flags: needinfo?(cyu)
Comment 11•9 years ago
|
||
All the deps are fixed, can we just get rid of the ifdefs for B2G now, or is there more that needs to be done here?
Updated•7 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•