Closed
Bug 980480
Opened 11 years ago
Closed 11 years ago
hit testing and boundaries fail on retina displays
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
*2 helps for hit testing, /2 doesn't help for position.
Robert, do you know what's special in Retina displays?
Updated•11 years ago
|
Summary: hit testing and boundareis fail on rethina displays → hit testing and boundaries fail on retina displays
Comment 2•11 years ago
|
||
Retina displays are high DPI. Is this bug referring to something internal to Firefox or did you test it using an AT?
In Windows, Firefox is DPI aware and exposes physical coordinates, so as long as the AT is DPI aware, it should just work. Note that NVDA 2013.3 and earlier aren't DPI aware, so this caused nasty problems until high DPI awareness was implemented.
Assignee | ||
Comment 3•11 years ago
|
||
It's rather something Firefox internal because Chrome works with VoiceOver just fine
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8387669 -
Flags: review?(trev.saunders)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → surkov.alexander
Comment 5•11 years ago
|
||
Comment on attachment 8387669 [details] [diff] [review]
patch
> nsCOMPtr<nsIAccessible> deepestFoundChild;
>- mGeckoAccessible->GetDeepestChildAtPoint((int32_t)geckoPoint.x,
>- (int32_t)geckoPoint.y,
>+ mGeckoAccessible->GetDeepestChildAtPoint(geckoPoint.x,
>+ geckoPoint.y,
> getter_AddRefs(deepestFoundChild));
while your here you might as well change that to ChildAtPoint(x, y, eDeepestChild)
Attachment #8387669 -
Flags: review?(trev.saunders) → review+
Comment 6•11 years ago
|
||
Comment on attachment 8387669 [details] [diff] [review]
patch
>diff --git a/accessible/src/mac/mozAccessible.mm b/accessible/src/mac/mozAccessible.mm
>+ NSView* mainView = (NSView*)[[NSScreen screens] objectAtIndex:0];
These all need to be NSScreen instead of NSView.
Assignee | ||
Comment 7•11 years ago
|
||
landed with comments addressed http://hg.mozilla.org/integration/mozilla-inbound/rev/9cf34c82f975
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•