Closed Bug 980529 Opened 11 years ago Closed 7 years ago

Bottom-left buttons should be visible on call stack tab as well

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jryans, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [polish-backlog][difficulty=easy])

When the left-hand Source / Call Stack panel is switched to Call Stack, you lose access to the 3 buttons on the bottom:

* Toggle blackboxing
* Toggle pretty print
* Toggle all breakpoints

These still make sense to use when on the Call Stack panel, but currently they disappear.
The idea was that these buttons are applicable to sources, not individual frames. One could make the case that the action would still correspond to the source that "contains" the selected frame, but it may be confusing, too. CCing Darrin for consultation.
I follow the argument that blackboxing and pretty printing are about manipulating particular sources.  But "toggle all breakpoints" is not tied to a particular source.

At the very least, it would be good to keep "toggle all breakpoints" accessible no matter what tab you are on.
It's true that "toggle all breakpoints" doesn't fit well in that conceptual model, but IIRC the thinking was that it would be ugly to have a toolbar with only one button and we couldn't find a better place for it. Bug 815280 has the details. This is not a black-and-white case of course, so perhaps we could revisit this. Maybe we should add the pause-on-exceptions button from bug 882790 there, to make a proper toolbar.
Summary: Bottom-left buttons should be visible on call stack tab → Bottom-left buttons should be visible on call stack tab as well
Whiteboard: [polish-backlog][difficulty=easy]
The new debugger doesn't have separate tabs here, so closing.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1288511, 1294139
Resolution: --- → FIXED
Product: Firefox → DevTools
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.