Closed
Bug 980723
Opened 11 years ago
Closed 7 years ago
No warnings or prompts before deleting a saved event
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(tracking-b2g:backlog, ux-b2g:2.2)
RESOLVED
WONTFIX
People
(Reporter: pdehaan, Assigned: gaye, NeedInfo)
References
Details
(Keywords: polish, Whiteboard: [fxos-bug-bash-1.4], ux-tracking, 2.6UXnom)
Attachments
(4 files)
Found using Jason's B2G 1.4 LG device
Steps to reproduce:
1. Launch the Calendar app
2. Create an event.
3. Click the event, and hit Edit.
4. In the event details, click the "Delete event" button.
Actual results:
The event is deleted. BOOM! No warning, no 'Are you sure', no confirmation whatsoever.
Expected results:
Courtesy warning of a destructive, non-undoable action.
Updated•11 years ago
|
Whiteboard: [fxos-bug-bash-1.4]
Comment 2•11 years ago
|
||
Not a blocker - not a regression & a nice to have at best.
blocking-b2g: 1.3? → backlog
Updated•11 years ago
|
Whiteboard: [fxos-bug-bash-1.4] → [fxos-bug-bash-1.4], ux-most-wanted
Updated•11 years ago
|
Assignee: nobody → joshua-smith
Comment 3•11 years ago
|
||
I am a bit unsure about the localization integration, so it would be great if someone could double-check that part specifically.
Attachment #8421281 -
Flags: review?(kgrandon)
Comment 4•11 years ago
|
||
Comment on attachment 8421281 [details]
PR on GitHub
Interesting, I filed bug 814337 for this exact issue, but was told that we should use an undo pattern. I'm not against landing this though as we have a confirmation pattern elsewhere in the system (contacts app for example).
Comment 5•11 years ago
|
||
Comment on attachment 8421281 [details]
PR on GitHub
Hey Joshua - thanks for the patch! Unfortunately I can't R+ yet due to some linter issues on travis, but if you can fix those I will take another look.
Also - do you think you could add a unit test for this case which ensures that confirm is called? If you don't think you can add the test, or need guidance on creating unit tests, let me know and I can help out. It should be able to stub the confirm function with something like: https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/test/unit/activity_handler_test.js#L675
Attachment #8421281 -
Flags: review?(kgrandon) → feedback+
Updated•11 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → Other
Comment 6•11 years ago
|
||
Nice!
Comment 7•11 years ago
|
||
I am still working on the Unit Tests for this. Please stay tuned =)
Comment 9•10 years ago
|
||
All: my apologies for the delay on fixing this bug. If someone could assist me with creating a unit test, that would be great!
Comment 10•10 years ago
|
||
let's confirm with UX first what is the expected behavior and what message should we display.
Flags: needinfo?(hhsu)
Comment 11•10 years ago
|
||
I think a confirmation dialog with a message "Delete event?" will be sufficient for this case. Attaching a screenshot for reference.
Flags: needinfo?(hhsu)
Updated•10 years ago
|
ux-b2g: --- → 2.2
Whiteboard: [fxos-bug-bash-1.4], ux-most-wanted → [fxos-bug-bash-1.4], ux-most-wanted-nov2014
Updated•10 years ago
|
Whiteboard: [fxos-bug-bash-1.4], ux-most-wanted-nov2014 → [fxos-bug-bash-1.4], ux-most-wanted-nov2014, 2x-uxnom
Comment 12•10 years ago
|
||
Now that we have UX guidance, we can proceed with the unit tests. Miller, can you assist me?
Flags: needinfo?(mmedeiros)
Updated•10 years ago
|
Whiteboard: [fxos-bug-bash-1.4], ux-most-wanted-nov2014, 2x-uxnom → [fxos-bug-bash-1.4], ux-most-wanted-nov2014, 2x-uxnom, polish
Comment 13•10 years ago
|
||
I have rebased my pull request: https://github.com/mozilla-b2g/gaia/pull/19173
Comment 14•10 years ago
|
||
Joshua, it would be great if you implemented marionette tests instead of a unit test for this feature (https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_integration_tests) you can see the other tests inside "apps/calendar/test/marionette/" for reference.
I would expect 2 tests, basically `app.createEvent() + app.monthDay.events[0].click() + app.readEvent.waitForDisplay() + app.readEvent.edit() + app.editEvent.waitForDisplay() + app.editEvent.delete()` and check if event was deleted after you confirm/cancel.
Flags: needinfo?(mmedeiros)
Assignee | ||
Comment 15•10 years ago
|
||
Sorry didn't mean to snipe work (I started working on this without looking at bug history). I hope I didn't disrupt anyone's work. I did go ahead and add the two marionette tests that Miller requested though.
Attachment #8549122 -
Flags: review?(mmedeiros)
Assignee | ||
Updated•10 years ago
|
Assignee: thewanuki → gaye
Comment 16•10 years ago
|
||
No problem! I have been swamped with other work, and this needs to be fixed soon.
Updated•10 years ago
|
Keywords: polish
Whiteboard: [fxos-bug-bash-1.4], ux-most-wanted-nov2014, 2x-uxnom, polish → [fxos-bug-bash-1.4], ux-most-wanted-nov2014, 2x-uxnom
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
Comment 17•10 years ago
|
||
Hey Gareth -
I came across this issue today and found this bug in my bugzilla search - it looks like your patch 'stalled out' in the review process?
Can you help get this moving again?
Flags: needinfo?(gaye)
Updated•9 years ago
|
Whiteboard: [fxos-bug-bash-1.4], ux-most-wanted-nov2014, 2x-uxnom → [fxos-bug-bash-1.4], ux-tracking, 2.6UXnom
Comment 18•9 years ago
|
||
Comment 19•9 years ago
|
||
In spite this bug already have 2 open PRs submitted a year ago we have been asked by Morpheus to check it. So, this is the third attempt.
Actually I just took Joshua's source code and rebased it on the latest master branch. Hope that it doesn't hurt anyone.
Updated•9 years ago
|
Attachment #8692922 -
Flags: review?(kevin+bugzilla)
Comment 20•9 years ago
|
||
Comment on attachment 8692922 [details]
[gaia] ruvsmirnov:bug-980723-notifications-deleting-event > mozilla-b2g:master
I think that this is incorrect and that we want to use an undo pattern instead, but Gareth should take a look here.
Attachment #8692922 -
Flags: review?(kevin+bugzilla) → review?(gaye)
Comment 21•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•