The NFC emulation should be able to receive and send NDEF messages. On top of this various test cases can be implemented. For sending, a test case would send an NDEF message using the WebAPI and read the message directly from the Emulator. For receiving the test case would write a message to the Emulator and try to receive it using the WebAPI.

I'm going to push the latest patches into this tree on github on a regular base. The code is constantly getting rebased and refactored, so don't make your patches depend on it. ;)

Updated github tree: - added basic NDEF support - added preliminary NDEF parser and commands to console

I'm setting this to 1.4 S5 to get the receiving working. Sending and receiving might be a bit optimistic.

Comment on attachment 8396438 [details] Latest code on github Updated github tree: - reworked SNEP and NDEF support - implemented RE infrastructure for sending SNEP PUT commands to guest - implemented construction of basic NDEF messages This is the first version of the code that injects an NDEF message into nfcd, although generating an error.

NFC isn't a 1.4 feature.

Comment on attachment 8396438 [details] Latest code on github Updated github tree: - fixed NDEF record structure - fixed SNEP version structure - fixed SNEP request construction It should now be able to inject NDEF messages into Gecko.

Comment on attachment 8396438 [details] Latest code on github Updated github tree: - cleanups - LLCP 'auto-connect' LLCP needs to establish a connection before data can be transmitted. The emulator now does this implicitly, which will simplify the implementation of test cases.

Comment on attachment 8396438 [details] Latest code on github Updated github tree: - fixed base64 decoding - added SNEP PUT read mode for reading received SNEP PUTs - cleanups - moved several patches into bug 995202 for merging

Comment on attachment 8396438 [details] Latest code on github Updated github tree: - added base64 encoding for outgoing strings - fixed JSON output of NDEF messages - keep track of last SAPs to simplify console interface

The test case sends and NDEF messages using NfcPeer.sendNDEF and reads back the message from the emulator. Validation is still missing.

This bug blocks NFC 2.0 release.

Comment on attachment 8396438 [details] Latest code on github Landed as part of bug 1000935.

Comment on attachment 8408338 [details] [diff] [review] Half-finished test case for NfcPeer.sendNDEF Landed as part of bug 1000935.

I spent some time to finish this bug and add a test case. This PR has patches for qemu to make receiving in P2P mode work.

Mostly cleanups in preparation of the actual test case. This patch depends on bug 1016777.

I'm on PTO during S3, so setting milestone to S4.

Comment on attachment 8430108 [details] [diff] [review] [02] Bug 980851: Added Marionette test case for receiving NDEF message on P2P mode Review of attachment 8430108 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/nfc/tests/marionette/test_nfc_manager_tech_discovered_ndef.js @@ +51,5 @@ > +SpecialPowers.pushPermissions( > + [{'type': 'nfc', 'allow': true, > + 'read': true, 'write': true, context: document}, > + {'type': 'nfc-manager', 'allow': true, context: document}, > + {'type': 'settings', 'allow': true, context: document}], runTests); 'setting' can be removed

Comment on attachment 8430102 [details] Github pull request for qemu patches Looks good, thanks!

Changes since v1: - rebased onto latest Gecko rev

Changes since v1: - rebased onto latest Gecko rev - don't acquire special power 'settings'

TBPL run: https://tbpl.mozilla.org/?tree=Try&rev=e784dee72656

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #22) > TBPL run: > > https://tbpl.mozilla.org/?tree=Try&rev=e784dee72656 This doesn't look good... https://tbpl.mozilla.org/php/getParsedLog.php?id=41435201&tree=Try

Also, please try to be more conscientious which jobs you run on your Try push. "All" runs like that use a LOT of machine resources. https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Changes since v2: - fixed syntax error in test case

Changes since v3: - cleaned up commit message

TBPL run: https://tbpl.mozilla.org/?tree=Try&rev=0f4052665e1a

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #27) > TBPL run: > > https://tbpl.mozilla.org/?tree=Try&rev=0f4052665e1a Failed, but meanwhile bug 1020034 has landed. It fixes a regression that affects the NFC code. Trying again: https://tbpl.mozilla.org/?tree=Try&rev=ab4b97c0c6c5

Changes since v4: - add missing '}' TBPL: https://tbpl.mozilla.org/?tree=Try&rev=ac49a500a5fe

Changes since v5: - cleaned up commit message

Tests are green now.

https://hg.mozilla.org/integration/b2g-inbound/rev/58f27112238c https://hg.mozilla.org/integration/b2g-inbound/rev/5a0ae35dbf7b

https://hg.mozilla.org/mozilla-central/rev/58f27112238c https://hg.mozilla.org/mozilla-central/rev/5a0ae35dbf7b