Closed
Bug 981427
Opened 11 years ago
Closed 11 years ago
CppEclipse usability improvements for b2g
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: BenWa, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #981411 +++
This fixes the build system, launch configuration, disables the scanner (slow and useless).
Attachment #8388227 -
Flags: review?(botond)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8388227 [details] [diff] [review]
patch
Review of attachment 8388227 [details] [diff] [review]:
-----------------------------------------------------------------
::: python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ +139,5 @@
> + launch = launch.replace('@LAUNCH_PROGRAM@', exe_path)
> + launch = launch.replace('@LAUNCH_ARGS@', '-P -no-remote')
> + fh.write(launch)
> +
> + if self.environment.substs['MOZ_WIDGET_TOOLKIT'] == 'gonk':
Any reason this isn't an 'else' to the above 'if'?
Attachment #8388227 -
Flags: review?(botond) → review+
|
Reporter | |
Comment 2•11 years ago
|
||
Because in the future it's going to be a if desktop ... elseif fennec elseif gonk.
|
|
Reporter | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•