Closed
Bug 981428
Opened 11 years ago
Closed 11 years ago
Move OSX -framework flags to moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ehsan
Blocks: xulinmozbuild
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8388230 -
Flags: review?(mshal)
Attachment #8388230 -
Flags: review?(mh+mozilla)
Attachment #8388230 -
Flags: review?(gps)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8388230 [details] [diff] [review]
Move OSX -framework flags to moz.build
>diff --git a/dom/plugins/test/testplugin/moz.build b/dom/plugins/test/testplugin/moz.build
>index 678c75f..8b405ea 100644
>--- a/dom/plugins/test/testplugin/moz.build
>+++ b/dom/plugins/test/testplugin/moz.build
>@@ -7,8 +7,11 @@
> DIRS += ['secondplugin', 'javaplugin']
>
> LIBRARY_NAME = 'nptest'
>
> FAIL_ON_WARNINGS = not CONFIG['_MSC_VER']
>
> relative_path = '.'
> include('testplugin.mozbuild')
>+
>+if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa' and '64' in CONFIG['OS_TEST']:
>+ EXTRA_DSO_LDOPTS += ['-framework Carbon']
Since this came from testplugin.mk, I think these lines need to go into testplugin.mozbuild so it will be included by testplugin/, testplugin/secondplugin, and testplugin/javaplugin.
Attachment #8388230 -
Flags: review?(mshal)
Attachment #8388230 -
Flags: review?(mh+mozilla)
Attachment #8388230 -
Flags: review?(gps)
Attachment #8388230 -
Flags: review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•