I noticed this when doing tests for bug 932356. Apparently there's code in value_selector.js to reset the Date Picker when language changes, but not for Time Picker. I think I understand have to fix this issue, replicating what's been done for Date Picker, going to take a better look in the next days.

Not urgent, so I'll leave this for :kaze when he's back. There are two problems in the current code: * We need to "uninit" the Time Picker when language changes, but just setting it to "not initialized" is not enough. Format changes, but reels act funny (wrong positions, am/pm double). Not sure if what I'm resetting is enough. * We add a class to picker-container, which is not good (classes pile up at every language change). Patch works fine on my Keon.

Note to reproduce: you need to open time picker at least once in the previous language. Example: 1. Open time picker with phone set to English 2. Switch to French 3. Open time picker, it will still use 12h format

Comment on attachment 8388543 [details] Github PR LGTM

Thanks Kaze, I should be done for a while with review requests ;-)

Master: https://github.com/mozilla-b2g/gaia/commit/7bd0dd8a09de391cb296957b1666a061d5805da6

Verified on Keon, Commit Git 2014-03-24 b9fffe49