Closed
Bug 981728
Opened 11 years ago
Closed 11 years ago
Spidermonkey reports a syntax error in browser.js
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
I have a thing in my local build scripts that checks for JS syntax errors. And it found one!
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8388681 -
Flags: review?(wjohnston)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8388681 -
Flags: review?(wjohnston)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8388609 -
Attachment is obsolete: true
|
||
Updated•11 years ago
|
Attachment #8388681 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8388681 [details] [diff] [review]
1-doubletap-dc9d7be
Review of attachment 8388681 [details] [diff] [review]:
-----------------------------------------------------------------
Hmm.. Its weird that we're not seeing this in our local consoles...
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yeah, it is. For the record, the way I'm checking is using a locally-built standalone spidermonkey binary (instructions at [1]; I tested with the latest m-c code) and the script at https://github.com/staktrace/moz-scripts/blob/master/jscheck where "js.$(uname)" points to the spidermonkey binary. The first line of the jscheck script deals with preprocessor goop, and AFAICT doesn't interfere with this particular bug.
[1] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Build_Documentation
|
||
Updated•11 years ago
|
Attachment #8388681 -
Flags: review?(wjohnston)
|
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•