Closed Bug 981882 Opened 10 years ago Closed 10 years ago

Update input field design

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: swilkes, Assigned: arnau)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken )

Attachments

(2 files, 1 obsolete file)

patch in github
(deleted), text/x-github-pull-request
pivanov
: review+
Details
inputs (device capture)
(deleted), image/png
pabratowski
: ui-review+
Details 
Przemek will attach new assets for the updated input field design to this bug and then either flag or reassign to Arnau.

For context, the FKA "common controls" work that will be included in 2.0 consists of buttons, special buttons, input fields and value selectors.
Blocks: 2.0-visual-refresh
Attached image inputs after patch (obsolete) (deleted) — 

        Attachment #8391114 -
        Flags: ui-review?(pabratowski)

    
    

    
  

      
      
      
      

        Attached file
          
        patch in github (deleted)
        — 
      

    


  

        Attachment #8391137 -
        Flags: review?(pivanov)
Assignee: pabratowski → arnau

    
    

    
  
Comment on attachment 8391114 [details]
inputs after patch

Input fields look good but the font is not the real italic version of the font.

        Attachment #8391114 -
        Flags: ui-review?(pabratowski) → ui-review-

    
    

    
  

      
      
      
      

        Attached image
          
        inputs (device capture) (deleted)
        — 
      

    


  

        Attachment #8391114 -
        Attachment is obsolete: true

        Attachment #8392901 -
        Flags: ui-review?

        Attachment #8392901 -
        Flags: ui-review? → ui-review?(pabratowski)

    
    

    
  
Comment on attachment 8392901 [details]
inputs (device capture)

Looks good.

        Attachment #8392901 -
        Flags: ui-review?(pabratowski) → ui-review+

    
    

    
  
Comment on attachment 8391137 [details]
patch in github

LGTM :) just see what travis said

        Attachment #8391137 -
        Flags: review?(pivanov) → review+

    
    

    
  
Travis is green ;)

Merged: 2e65ad99b09ce412ebdae028cfaeaf774d826fb0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → 2.0+

          status-b2g-v2.0:
          --- → fixed
Target Milestone: --- → 2.0 S1 (9may)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: