Closed
Bug 981920
Opened 11 years ago
Closed 11 years ago
ASAN builds should use -fno-omit-frame-pointer by default
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
ASAN uses a fast stack unwinder that relies on frame pointers. ASAN builds on TBPL are optimized, and at least based on the try pushed I've done, do not seem to have -fno-omit-frame-pointer, resulting in some useless stacks in LSAN reports I've been investigating. Locally, adding "ac_add_options --enable-profiling" to my mozconfig fixed the problem with the stacks. Maybe tying this to "ac_add_options --enable-address-sanitizer" is the way to go?
I'm not entirely sure what is required for this, but it seems like it would require modifying /build/autoconf/frameptr.m4 .
Decoder, is there anything you do in your ASAN runs to deal with this?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8389344 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 2•11 years ago
|
||
In IRC, decoder said he thought we already had profiling enabled for ASAN builds, so he'd be okay with something like this.
Updated•11 years ago
|
Attachment #8389344 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thanks for the review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ee12861380
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•