Peter Van der Beken [:peterv] Assignee
	Description • 10 years ago

      No description provided.

	Boris Zbarsky [:bzbarsky]
	Comment 1 • 10 years ago

Comment on attachment 8389176 [details] [diff] [review]
v1

> @@ -7471,26 +7471,25 @@ nsGlobalWindow::CallerInnerWindow()

Please document that we can't just xpc::WindowOrNull because we want to be able to tell apart the cases of "scope is not an nsISupports at all" and "scope is an nsISupports that's not a window"?  In particular, in the former case we want to return null, but in the latter case we want to return GetCurrentInnerWindowInternal().

That said, is that _really_ a distinction we want to be making here?  Seems a bit odd to me.

r=me with the comment added or the code changed.  Changing in a followup is OK too.

	Peter Van der Beken [:peterv] Assignee
	Comment 2 • 10 years ago

Added a comment pointing to bug 984467.

http://hg.mozilla.org/integration/mozilla-inbound/rev/570a5c5c8e38

	Phil Ringnalda (:philor)
	Comment 3 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/570a5c5c8e38