Closed Bug 982114 Opened 11 years ago Closed 11 years ago

Deal with new DOM binding objects for Window in more places

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(1 file)

Attached patch v1 (deleted) — Splinter Review
No description provided.
Attachment #8389176 - Flags: review?(bzbarsky)
Blocks: 789261
Comment on attachment 8389176 [details] [diff] [review] v1 > @@ -7471,26 +7471,25 @@ nsGlobalWindow::CallerInnerWindow() Please document that we can't just xpc::WindowOrNull because we want to be able to tell apart the cases of "scope is not an nsISupports at all" and "scope is an nsISupports that's not a window"? In particular, in the former case we want to return null, but in the latter case we want to return GetCurrentInnerWindowInternal(). That said, is that _really_ a distinction we want to be making here? Seems a bit odd to me. r=me with the comment added or the code changed. Changing in a followup is OK too.
Attachment #8389176 - Flags: review?(bzbarsky) → review+
Blocks: 984467
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: