Closed
Bug 982114
Opened 11 years ago
Closed 11 years ago
Deal with new DOM binding objects for Window in more places
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8389176 -
Flags: review?(bzbarsky)
Comment 1•11 years ago
|
||
Comment on attachment 8389176 [details] [diff] [review]
v1
> @@ -7471,26 +7471,25 @@ nsGlobalWindow::CallerInnerWindow()
Please document that we can't just xpc::WindowOrNull because we want to be able to tell apart the cases of "scope is not an nsISupports at all" and "scope is an nsISupports that's not a window"? In particular, in the former case we want to return null, but in the latter case we want to return GetCurrentInnerWindowInternal().
That said, is that _really_ a distinction we want to be making here? Seems a bit odd to me.
r=me with the comment added or the code changed. Changing in a followup is OK too.
Attachment #8389176 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Added a comment pointing to bug 984467.
http://hg.mozilla.org/integration/mozilla-inbound/rev/570a5c5c8e38
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•