Closed Bug 982205 Opened 11 years ago Closed 11 years ago

Hide the facebook oauth frame so that we don't pay during painting

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

d331e651526b559028f21b662749edb3e419c216.patch
(deleted), patch
jmcf
: review+
crdlc
: feedback+
Details | Diff | Splinter Review
Everytime there's an iframe that we might need to draw we go down a relatively expensive path (Telling the background color to compositor shows up). Avoid that by making the oauth frame hidden.
Blocks: 982210
Cristian, Could you have a look at this, whenever you get the chance?
Flags: needinfo?(crdlc)
Jeff, please put your pr under review although it looks nice because of FTU is working with the same approach https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/ftu/index.html#L806
Flags: needinfo?(crdlc)
Attachment #8391192 - Flags: review?(crdlc)
Comment on attachment 8391192 [details] [diff] [review] d331e651526b559028f21b662749edb3e419c216.patch LGTM
Attachment #8391192 - Flags: review?(jmcf)
Attachment #8391192 - Flags: review?(crdlc)
Attachment #8391192 - Flags: feedback+
Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Attachment #8391192 - Flags: review?(jmcf) → review+
Merged in master: https://github.com/mozilla-b2g/gaia/commit/069cae26749e9a054682e1045f10d8efbb94d93b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: --- → 1.4?
We've deciding to not block on this since Milan thinks we might be able to live with some checkerboarding for 1.4 (going to confirm with QC to be sure). But this is definitely worth asking for approval on.
blocking-b2g: 1.4? → backlog
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: