Closed
Bug 982373
Opened 11 years ago
Closed 11 years ago
Leak of nsROCSSPrimitiveValue on early return from nsComputedDOMStyle::DoGetTextDecoration
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak, Whiteboard: [lsan][MemShrink])
Attachments
(1 file)
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Easy fix. I manually audited every |new| in nsComputedDOMStyle.cpp, and the rest look okay to me.
Comment 1•11 years ago
|
||
Yup, easy fix; we can just move the |val| decl down below the early returns.
mccr8, did you want to take this? I'll be happy to review, if so; otherwise, I'm happy to take.
Comment 2•11 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #1)
> mccr8, did you want to take this?
(missed that you assigned it to yourself; sorry for the unnecessary noise. :))
Updated•11 years ago
|
Priority: -- → P4
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8389939 [details] [diff] [review]
Don't leak val when we return early from nsComputedDOMStyle::DoGetTextDecoration().
Looks good to me.
Attachment #8389939 -
Flags: review+
Assignee | ||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•