Closed
Bug 982377
Opened 11 years ago
Closed 7 years ago
[Camera][Gecko] Improve camera logging
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mikeh, Assigned: mikeh)
References
Details
(Whiteboard: [priority])
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Right now everything goes through PRLog, but on Gonk we can do better, and make the logging output more consistent with the output from other modules. Also, the DOM_CAMERA_LOGT macros are almost always used to log function and line numbers--this can be balled into the macros themselves to reduce duplications.
Updated•11 years ago
|
Whiteboard: [priority]
Assignee | ||
Updated•11 years ago
|
Blocks: camera-backlog
Assignee | ||
Comment 1•11 years ago
|
||
- make it possible to easily log DOM-facing function calls/callbacks, even when all other logging is disabled.
Assignee | ||
Comment 2•10 years ago
|
||
- make it possible to enable logging using a pref, so that end-users can enable debugging - make it possible to enable logging from Gaia
Depends on: 1053966
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mhabicher
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
The first of three patches, all bitrotted, posted here so that others with more time may take them up.
Attachment #8526059 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
This patch adds %s:%d => __PRETTY_FUNCTION__, __LINE__ to DOM_CAMERA_LOGT calls implicitly. It also makes use of the Gonk LOG_TAG features on that platform (and emulates them on others).
Assignee | ||
Comment 7•10 years ago
|
||
Note that the above changes still make use of changing logging level on the fly without an atomic, which [1] suggests is a problem -- even if it seems benign. 1. https://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
Comment 8•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•