Closed Bug 982666 Opened 11 years ago Closed 6 years ago

Alt char menu reflows

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: janjongboom, Unassigned)

References

Details

When showing the alternative character menu it will do a bunch of reflows due to calling getWindowLeft. Should be fixed.
Rudy, could you re-confirm if this bug is still valid with the new alt style? If you have no tooling to find out this we can ask for help together.
Flags: needinfo?(rlu)
Just check the new menu, and we would still get one reflow from this line,
reflow: 23.51ms function AlternativesCharMenuView.prototype.getBoundingClientRect, alternatives_char_menu.js line 145

This is because we need to get the boundingRect of the menu to calculate the locked area (the area in which we could interact with the menu.)

We might be able to do some calculation as what we did in render.js for the menu size, but since we don't show/hide the menu frequently, I would think this is an issue with lower priority.

Let me know if you have any better idea to get rid of the reflow.
Thank you.
Flags: needinfo?(rlu)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.