Martin Stránský [:stransky] (ni? me) Assignee
	Description • 10 years ago

cairo-gtk3 can't be build with in-tree cairo, let's check that in configure script.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 1 • 10 years ago

Set system-cairo as default for gtk3 target and fails when user overrides it. Ted, can you check this one please?

	Rafał Mużyło
	Comment 2 • 10 years ago

Out of 'idle' curiosity, does firefox built against gtk3 still has the problem described in bug 862422 ?

As of firefox 27 and gtk2, it's still a present problem.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 3 • 10 years ago

(In reply to Rafał Mużyło from comment #2)
> Out of 'idle' curiosity, does firefox built against gtk3 still has the
> problem described in bug 862422 ?
> 
> As of firefox 27 and gtk2, it's still a present problem.

I don't think there's a difference in Gtk3 version so I expect the same problems here.

	Rafał Mużyło
	Comment 4 • 10 years ago

(In reply to Martin Stránský from comment #3)
> (In reply to Rafał Mużyło from comment #2)
> > Out of 'idle' curiosity, does firefox built against gtk3 still has the
> > problem described in bug 862422 ?
> > 
> > As of firefox 27 and gtk2, it's still a present problem.
> 
> I don't think there's a difference in Gtk3 version so I expect the same
> problems here.

In such case, any chance on *you* reopening it and adding it to the 'porting to gtk3' tracker ?
Cause if I'd do it, it would likely just get VERIFIED.

	(not currently active) Ted Mielczarek
	Comment 5 • 10 years ago

Comment on attachment 8389873 [details] [diff] [review]
cairo check patch

Review of attachment 8389873 [details] [diff] [review]:
-----------------------------------------------------------------

What's the problem with the in-tree cairo, does it just need an update to handle gtk3? (Is there a bug on that?)

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 6 • 10 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> Comment on attachment 8389873 [details] [diff] [review]
> cairo check patch
> 
> Review of attachment 8389873 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> What's the problem with the in-tree cairo, does it just need an update to
> handle gtk3? (Is there a bug on that?)

Thanks! There's a problem with system cairo, it causes flash plugin flickering. In-tree cairo works as expected.

	(not currently active) Ted Mielczarek
	Comment 7 • 10 years ago

Did you mean that the other way around? Your patch implements the opposite.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 8 • 10 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> Did you mean that the other way around? Your patch implements the opposite.

I know, it's because Gtk3 can't be build with in-tree cairo, the system one has to be used. IMO the flash flickering has to be fixed in cairo package shipped by linux distros.

	Rafał Mużyło
	Comment 9 • 10 years ago

(In reply to Martin Stránský from comment #8)
> (In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> > Did you mean that the other way around? Your patch implements the opposite.
> 
> I know, it's because Gtk3 can't be build with in-tree cairo, the system one
> has to be used. IMO the flash flickering has to be fixed in cairo package
> shipped by linux distros.

Are you sure this flickering isn't a bug in firefox ?
cairo 1.12 has been around for quite awhile already.
As I said, if system cairo should be mandatory for gtk3, bug 862422 should be revisited and potentially reopened.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac77c843076f

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/ac77c843076f